Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkcs7 chain building #30

Closed
oliwel opened this issue Dec 10, 2012 · 0 comments
Closed

Fix pkcs7 chain building #30

oliwel opened this issue Dec 10, 2012 · 0 comments

Comments

@oliwel
Copy link
Contributor

oliwel commented Dec 10, 2012

The code in the pkcs7_get_chain method of the default token is broken. It tries do build the chain using the issuer subject string. This fails for multivalued CNs as pkcs7 and openssl use different formats on stringified subjects.

CN=Oliver Welter/UID=oliwel,DC=OpenXPKI,DC=org vs.
UID=oliwel+CN=Oliver Welter,DC=OpenXPKI,DC=org

As this also can lead to ambigouty, suggested fix is to use AIA info as in certnanny to construct the chain https://github.com/certnanny/CertNanny/blob/master/agent/lib/perl/CertNanny/Keystore.pm#L1342

A continous formatting needs to be defined and implemented with respect to other issues and as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant