-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] yurt-iot-dock v1.4.1 doesn't match the edgex v3.1.0 #1992
Comments
@24sama Thank you for raising this issue. In fact, this should already be supported. We just need to add the napa case. Could you submit a pr to help fix this? |
@LavenderQAQ Got it, and I found this PR: Another question, if I build the yurt-iot-dock from release-v1.4 source code, Is it will miss some feature or bugfix PR which is compared to official v1.4.1 version? |
@24sama When 1.4 was released, there was no napa release yet. This is a more recent version that we support, and we can fix it directly on master. |
Thanks @LavenderQAQ , so it means there is only a master branch that supports napa release. And how soon is the official plan to release a new version with napa support? Just like this, we can checkout a new release branch that includes all master PR, and can build it from the release branch. |
@24sama we plan to release OpenYurt v1.5 in the middle of April, please stay in tune. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
What happened:
When I deploy yurt-iot-dock v1.4.1, I fount it doesn't match the edgex v3.1.0.
And I see the code logic of the release-v1.4 branch and v1.4.1 tag, which all don't contain the "napa".
openyurt/pkg/yurtiotdock/clients/edgex-foundry/edgexobject.go
Lines 44 to 69 in cb2055b
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:
kubectl version
):cat /etc/os-release
):uname -a
):others
/kind bug
The text was updated successfully, but these errors were encountered: