Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add yurtadm join node in specified nodepool #1402

Merged
merged 3 commits into from Jun 13, 2023
Merged

add yurtadm join node in specified nodepool #1402

merged 3 commits into from Jun 13, 2023

Conversation

JameKeal
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Yurtadm can support to join node into specified nodepool.

NodePool is one of the first class citizen in OpenYurt, more and more features will be added for NodePool, and node in OpenYurt cluster should belong to a NodePool, so node can be well managed.

Which issue(s) this PR fixes:

Fixes #1380

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

other Note

@openyurt-bot openyurt-bot added the kind/feature kind/feature label Apr 21, 2023
@openyurt-bot
Copy link
Collaborator

@JameKeal: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

Yurtadm can support to join node into specified nodepool.

NodePool is one of the first class citizen in OpenYurt, more and more features will be added for NodePool, and node in OpenYurt cluster should belong to a NodePool, so node can be well managed.

Which issue(s) this PR fixes:

Fixes #1380

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited

Codecov Report

Merging #1402 (88bab3f) into master (e9dce78) will increase coverage by 0.35%.
The diff coverage is 48.48%.

❗ Current head 88bab3f differs from pull request most recent head b7ad495. Consider uploading reports for the commit b7ad495 to get more accurate results

@@            Coverage Diff             @@
##           master    #1402      +/-   ##
==========================================
+ Coverage   50.49%   50.85%   +0.35%     
==========================================
  Files         133      133              
  Lines       15820    15852      +32     
==========================================
+ Hits         7989     8062      +73     
+ Misses       7099     7045      -54     
- Partials      732      745      +13
Flag Coverage Δ
unittests 50.85% <48.48%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/yurtadm/cmd/join/join.go 61.04% <26.31%> (+10.24%) ⬆️
pkg/util/kubeconfig/kubeconfig.go 51.76% <72.72%> (+3.11%) ⬆️
pkg/yurtadm/util/yurthub/yurthub.go 28.57% <100.00%> (+19.41%) ⬆️

... and 1 file with indirect coverage changes

@rambohe-ch
Copy link
Member

/hold

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Apr 21, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JameKeal
To complete the pull request process, please assign rambohe-ch
You can assign the PR to them by writing /assign @rambohe-ch in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch
Copy link
Member

@JameKeal The feature will be released in OpenYurt v1.4, so i hold it temporarily.

@JameKeal JameKeal force-pushed the yurtadm-join-node-in-nodepool branch from 627f569 to 19b7c4e Compare April 21, 2023 07:48
@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

@rambohe-ch
Copy link
Member

/unhold

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label May 22, 2023
@rambohe-ch
Copy link
Member

@JameKeal please fix the conflicting fiels.

@rambohe-ch rambohe-ch added this to the controlplane-v1.4 milestone May 22, 2023
@JameKeal
Copy link
Member Author

@JameKeal please fix the conflicting fiels.

OK, i will merge it and update the details.

@YTGhost
Copy link
Member

YTGhost commented Jun 12, 2023

Please fix the golangci-lint issue

@JameKeal JameKeal force-pushed the yurtadm-join-node-in-nodepool branch 2 times, most recently from ba53d7d to 5f08621 Compare June 12, 2023 09:29
@JameKeal JameKeal force-pushed the yurtadm-join-node-in-nodepool branch from 88bab3f to b7ad495 Compare June 12, 2023 09:43
@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JameKeal JameKeal requested a review from YTGhost June 12, 2023 11:09
@JameKeal JameKeal requested a review from rambohe-ch June 12, 2023 11:09
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jun 13, 2023
@rambohe-ch
Copy link
Member

/approve

@rambohe-ch rambohe-ch merged commit 731b71e into openyurtio:master Jun 13, 2023
12 of 14 checks passed
@JameKeal JameKeal deleted the yurtadm-join-node-in-nodepool branch June 13, 2023 06:39
@open-digger-bot open-digger-bot bot mentioned this pull request Jun 14, 2023
Closed
@rambohe-ch rambohe-ch mentioned this pull request Jun 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@adamzhoul adamzhoul Awaiting requested review from adamzhoul

@zzguang zzguang Awaiting requested review from zzguang

@YTGhost YTGhost Awaiting requested review from YTGhost

Assignees

@rambohe-ch rambohe-ch

Labels
kind/feature kind/feature lgtm lgtm size/L size/L: 100-499
Projects
None yet
Milestone
controlplane-v1.4
Development

Successfully merging this pull request may close these issues.

[feature request]support join node in specified nodepool
4 participants
@JameKeal @openyurt-bot @rambohe-ch @YTGhost