Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change access permission to default in general. #1599

Merged
merged 1 commit into from Jul 11, 2023
Merged

change access permission to default in general. #1599

merged 1 commit into from Jul 11, 2023

Conversation

fujitatomoya
Copy link
Contributor

backport of #1576 for release-v1.0

What type of PR is this?

/kind bug

@fujitatomoya
change access permission to default in general.
ffbcb6d 
  backport of openyurtio#1576 for release-v1.0

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@openyurt-bot openyurt-bot added kind/bug kind/bug size/XS size/XS: 0-9 labels Jul 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

fujitatomoya
fujitatomoya commented Jul 10, 2023
View reviewed changes
Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, requesting maintainer review.

@fujitatomoya fujitatomoya mentioned this pull request Jul 10, 2023
Merged
YTGhost
YTGhost reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Jul 10, 2023
@fujitatomoya
Copy link
Contributor Author

https://sonarcloud.io/project/issues?id=openyurtio_openyurt&pullRequest=1599&resolved=false&types=CODE_SMELL is unrelated.

@rambohe-ch friendly ping.

@rambohe-ch rambohe-ch merged commit a4f83a8 into openyurtio:release-v1.0 Jul 11, 2023
1 of 8 checks passed
@open-digger-bot open-digger-bot bot mentioned this pull request Jul 12, 2023
Closed
@fujitatomoya
Copy link
Contributor Author

@YTGhost @rambohe-ch

when this branch is synced with tag v1.1.0 ? that is the version tag we detected this problem? i am not really familiar with release procedure, could you share the thought?

@YTGhost
Copy link
Member

YTGhost commented Jul 12, 2023

@YTGhost @rambohe-ch

when this branch is synced with tag v1.1.0 ? that is the version tag we detected this problem? i am not really familiar with release procedure, could you share the thought?

@fujitatomoya we have a new tag v1.1.1, see: https://github.com/openyurtio/openyurt/releases/tag/v1.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YTGhost YTGhost YTGhost left review comments

@Congrool Congrool Awaiting requested review from Congrool

@huangyuqi huangyuqi Awaiting requested review from huangyuqi

Assignees

@YTGhost YTGhost

Labels
kind/bug kind/bug lgtm lgtm size/XS size/XS: 0-9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fujitatomoya @YTGhost @rambohe-ch @openyurt-bot