Add support for the conversion between kind and OpenYurt cluster #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peeknut
force-pushed
the
kind
branch
2 times, most recently
from
399d955
to
10dff86
Compare
charleszheng44
suggested changes
Mar 11, 2021
| @@ -231,7 +231,7 @@ spec: | |||
| - /bin/sh | |||
| - -c | |||
| args: | |||
| - "nsenter -t 1 -m -u -n -i -- /bin/yurtctl revert edgenode" | |||
| - "cp /usr/local/bin/yurtctl /tmp && nsenter -t 1 -m -u -n -i -- /var/tmp/yurtctl revert edgenode && rm /tmp/yurtctl" | |||
There was a problem hiding this comment.
Same as the previous comment.
| return "", err | ||
| } else if nodeName != "" { | ||
| nodeName, _ := GetSingleContentFromFile(KubeletSvcPath, KubeletHostname) | ||
| if nodeName != "" { |
There was a problem hiding this comment.
Can we log the error instead of ignoring it?
| return "", err | ||
| } else if nodeName != "" { | ||
| nodeName, _ = GetSingleContentFromFile(ef, KubeletHostname) | ||
| if nodeName != "" { |
There was a problem hiding this comment.
Same as the previous comment.
rambohe-ch
approved these changes
Mar 30, 2021
|
/lgtm |
charleszheng44
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
1.Only one node in the cluster is installed with openyurt, and then any node in the cluster can be converted.
2.Add support for the conversion between kind and OpenYurt cluster.
Ⅱ. Does this pull request fix one issue?
fixes #230.
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
make test
make build
cp _output/bin/yurtctl /bin/
yurtctl convert
yurtctl revert
Ⅴ. Special notes for reviews