Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: delete files that remain in the os /tmp directory after the test #529

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Test: delete files that remain in the os /tmp directory after the test #529

merged 1 commit into from
Oct 25, 2021

Conversation

windydayc
Copy link
Member

@windydayc windydayc commented Oct 22, 2021 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind enhancement

What this PR does / why we need it:

This PR delete files that remain in the os /tmp directory after the test, such as /tmp/cache-manager/, /tmp/cache-manager/ and so on.
This PR fix some English grammer errors.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @qclc

Does this PR introduce a user-facing change?

   After unit testing, the os /tmp directory will no longer see any residual files.

other Note

@openyurt-bot
Copy link
Collaborator

@windydayc: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage
/kind enhancement

What this PR does / why we need it:

This PR delete files that remain in the os /tmp directory after the test, such as /tmp/cache-manager/, /tmp/cache-manager/ and so on.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @qclc

Does this PR introduce a user-facing change?

  After unit testing, the os /tmp directory will no longer see any residual files.

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/enhancement kind/enhancement label Oct 22, 2021
@openyurt-bot openyurt-bot added the size/M size/M: 30-99 label Oct 22, 2021
@openyurt-bot
Copy link
Collaborator

Welcome @windydayc! It looks like this is your first PR to openyurtio/openyurt 🎉

@windydayc windydayc changed the title Fix test Test: delete files that remain in the os /tmp directory after the test Oct 22, 2021
@rambohe-ch
Copy link
Member

@windydayc please fix golangci-lint error.

@windydayc
Test: delete residual files in /tmp after the test
299e33a 
Delete the directory /tmp/cache-manager after testing the cachemanager/cache_manager_test.go
Delete the directory /tmp/cache-local after testing the proxy/local/local_test.go
Delete the directory /tmp/healthz after testing the
healthchecker/health_checker_test.go
Fix some English grammer errors
@windydayc
Copy link
Member Author

@windydayc please fix golangci-lint error.

@rambohe-ch I have fixed this golangci-lint error that occured in pkg/yurthub/proxy/local/local_test.go#L142.

@qclc
Copy link
Member

qclc commented Oct 23, 2021 •
edited
Loading

The modification looks good for me.

@qclc
Copy link
Member

qclc commented Oct 23, 2021

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Oct 23, 2021
@rambohe-ch
Copy link
Member

@windydayc Thank you for raising pull request. welcome you to apply OpenYurt community member, you can reference example here: openyurtio/community#30

/approve

@openyurt-bot openyurt-bot added the approved approved label Oct 25, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, windydayc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit e3b0f65 into openyurtio:master Oct 25, 2021
@windydayc windydayc mentioned this pull request Oct 25, 2021
Closed
6 tasks
@windydayc windydayc deleted the fix_test branch October 25, 2021 05:45
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Oct 30, 2021
@windydayc @Congrool
Test: delete residual files in /tmp after the test (openyurtio#529)
2be96b2 
Delete the directory /tmp/cache-manager after testing the cachemanager/cache_manager_test.go
Delete the directory /tmp/cache-local after testing the proxy/local/local_test.go
Delete the directory /tmp/healthz after testing the
healthchecker/health_checker_test.go
Fix some English grammer errors
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
@windydayc
Test: delete residual files in /tmp after the test (openyurtio#529)
72ea634 
Delete the directory /tmp/cache-manager after testing the cachemanager/cache_manager_test.go
Delete the directory /tmp/cache-local after testing the proxy/local/local_test.go
Delete the directory /tmp/healthz after testing the
healthchecker/health_checker_test.go
Fix some English grammer errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peeknut Peeknut Awaiting requested review from Peeknut

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@qclc qclc

Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/M size/M: 30-99
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@windydayc @openyurt-bot @rambohe-ch @qclc