-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
-Add steps to create kind -Change the name of the error and the latest version number -Add helm deployment method
-changes to a newer image of k8s cluster
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 18.40% 18.40%
=======================================
Files 2 2
Lines 402 402
=======================================
Hits 74 74
Misses 322 322
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tools/collector/edgex/collect.go
Outdated
for i, version := range versions { | ||
components := version.Components | ||
newArray := make([]string, 0) | ||
for j, _ := range components { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underline is redundant
for j := range components
go.mod
Outdated
@@ -8,6 +8,7 @@ require ( | |||
github.com/onsi/gomega v1.19.0 | |||
github.com/openyurtio/api v0.0.0-20220907024010-e5bfc9cc1b4b | |||
github.com/pkg/errors v0.9.1 | |||
github.com/sirupsen/logrus v1.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yurt-edgex-manager
does not use logrus
library. Try to delete it, then run go mod tidy
.
Another problem is that we need to replace the original image repo prefix in the configuration file with openyurt instead. - name: edgex-device-rest
image: edgexfoundry/device-rest:2.3.0
volumns:
- name: edgex-init
hostPath: /edgex-init
mountPath: /edgex-init
- name: anonymous_volume1
hostPath: /tmp/edgex/secrets/device-rest
mountPath: /tmp/edgex/secrets/device-rest
ports:
- protocol: TCP
port: 59986
targetPort: 59986
componentEnv:
SERVICE_HOST: edgex-device-rest Replace to: - name: edgex-device-rest
image: openyurt/device-rest:2.3.0
volumns:
- name: edgex-init
hostPath: /edgex-init
mountPath: /edgex-init
- name: anonymous_volume1
hostPath: /tmp/edgex/secrets/device-rest
mountPath: /tmp/edgex/secrets/device-rest
ports:
- protocol: TCP
port: 59986
targetPort: 59986
componentEnv:
SERVICE_HOST: edgex-device-rest |
You can pass the .PHONY: run
run:
go run main.go --debug=$(DEBUG) --repo=$(REPO) |
I'm going to fix these problem right away. |
tools/collector/edgex/collect.go
Outdated
"github.com/sirupsen/logrus" | ||
) | ||
|
||
var ( | ||
collectLog *logrus.Entry | ||
branchesURL = "https://github.com/edgexfoundry/edgex-compose/branches/all" | ||
extractVersionRegexp = `branch="(.*?)"` | ||
singleArchPath = "./config/singlearch_imagelist.txt" | ||
multiArchPath = "./config/multiarch_imagelist.txt" | ||
repoName = "openyurt/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The repo name should be read from the makefile to make debugging easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,I will change it.
/lgtm |
What type of PR is this?
What this PR does / why we need it:
Merge the crawled images into single-architecture and multi-architecture, and push to openyurt
Which issue(s) this PR fixes:
Fixes #60