-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about opening in Remix when choosing upgradeability #63
Comments
Was just coming here to post this. |
Added a warning in c5c84fa. |
Sorry for bothering but as a new comer I find the warning easily overlooked as it only shows as a bubble dialog on mouse hover. This information is not very accessible by Googling either. At least we should show a static noticeable warning message "⚠ Remix cannot be used for upgradeable contracts " next to the "Open in Remix" option IMO. |
Thanks for the suggestion @cyanlink. Do you suggest the warning should be visible even before selecting upgradeability? |
I would prefer not to because without upgradeability Remix IDE is all right. It's still conventional contract code that does not need extra setup. When upgradeability selected, a sudden appearance of a warning sign can better draw user's attention than a constant warning. |
After going back to the wizard website I reconsidered. The warning should be displayed in a even more noticeable way, because the webpage is scrollable, when we scroll down to select upgradeability, then scroll back to top to reach the export buttons, we might still overlook if the appeared warning is placed near the buttons. Maybe it should be right under the Upgradeability options section when toggled, and if we check the checkbox we can instantly see it; or we can even pop up a modal dialog for acknowledgement when user try to open in remix when toggled. |
Ok, in e42c3fb I've made it so the button is disabled for upgradeable contracts and actually opening in Remix requires an additional click inside the tooltip. Check it out please! |
The user may not be aware that upgradeable contracts have to be deployed behind a proxy, and deploying with Remix may produce unexpected results. Example support request.
The text was updated successfully, but these errors were encountered: