-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Stoppable to Pausable #6
Comments
Hi! I'm interested in tackling this issue, since I'm still scared of open source contributions, and this one seems pretty manageable. So, just to make sure, here's what I've done: I cloned the whole project and then replaced all instances of 'Stoppable' to 'Pausable'. Now, How do I run tests for it? Thanks in advance and sorry for the silly question! |
Hi @JGcarv, thanks for taking the time to contribute to OpenZeppelin. You should be able to run the tests with
|
Hey @federicobond , thanks for the reply! So, I installed the dependencies and ran the tests(which were all passing) but when I tried to
Do you have any idea what it might be? Thanks! |
Yes, you cannot push directly to the OpenZeppelin fork because you are not a collaborator. You should make your own fork on GitHub and configure your local clone to push there, like this:
Once you do that, you will be able to push your branch:
If you want to pull updates from the official fork later, you can then do so like this:
|
Yeah, that makes sense. Anyway, I followed the steps and made a new pull request. Let me know if things do work out. Also, thank you for your patience! |
Great work @JGcarv, closing this :) |
See Pause in http://vessenes.com/we-need-some-best-practices-for-smart-contracts/
The text was updated successfully, but these errors were encountered: