This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
7586 remove #ifdef __lint hack from dmu.h #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zettabot go |
gwr
reviewed
Dec 2, 2016
| @@ -564,12 +564,7 @@ typedef struct dmu_buf_user { | |||
| * NOTE: This function should only be called once on a given dmu_buf_user_t. | |||
| * To allow enforcement of this, dbu must already be zeroed on entry. | |||
| */ | |||
| #ifdef __lint | |||
| /* Very ugly, but it beats issuing suppression directives in many Makefiles. */ | |||
There was a problem hiding this comment.
Is this really "better"? You're trading away the ability to notice unused statics, which seems to me a high price to pay to get rid of an #ifdef __lint.
There was a problem hiding this comment.
gcc will detect unused statics correctly but not get tripped up by inline functions. So it's true that lint won't notice, but as long a we aren't gagging unused functions, it should be fine.
There was a problem hiding this comment.
If it's only lint that won't notice unused statics, then OK.
dankimmel
force-pushed
the
openzfs.7586-ifdef__lint-hack
branch
2 times, most recently
from
7cc3603
to
81f06b1
Compare
Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> The #ifdef __lint in dmu.h is ugly, and it would be nice not to duplicate it if we add other inline functions into header files in ZFS, especially since it is difficult to make any other solution work across all compilation targets. We should switch to disabling the lint flags that are failing instead.
dankimmel
force-pushed
the
openzfs.7586-ifdef__lint-hack
branch
from
81f06b1
to
34728f0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by: Matthew Ahrens mahrens@delphix.com
Reviewed by: Pavel Zakharov pavel.zakharov@delphix.com
The
#ifdef __lintindmu.his ugly, and it would be nice not toduplicate it if we add other inline functions into header files in ZFS,
especially since it is difficult to make any other solution work across
all compilation targets. We should switch to disabling the lint flags
that are failing instead.
Upstream bugs: DLPX-44715