Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Add notifications when a scrub is paused or resumed. #495

Closed
wants to merge 3 commits into from
Closed

Add notifications when a scrub is paused or resumed. #495

wants to merge 3 commits into from

Conversation

kithrup
Copy link

@kithrup kithrup commented Nov 9, 2017

Notification when scrub is aborted taken from FreeBSD, the other two were modeled on that.

The change has been tested on FreeNAS.

Notification when scrub is aborted taken from FreeBSD.

The change has been tested on FreeNAS.
@@ -203,6 +203,9 @@ extern "C" {
#define ESC_ZFS_CONFIG_SYNC "ESC_ZFS_config_sync"
#define ESC_ZFS_SCRUB_START "ESC_ZFS_scrub_start"
#define ESC_ZFS_SCRUB_FINISH "ESC_ZFS_scrub_finish"
#define ESC_ZFS_SCRUB_ABORT ""ESC_ZFS_scrub_abort"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's a typo here (two "")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blast it. I thought I'd made that by patching. Hold on a bit while I fix it. grumble.

@ahrens
Copy link
Member

ahrens commented Dec 20, 2017

You'll need to fix the compilation errors, which you can see by clicking "Details" next to the failed check:

../../common/fs/zfs/dsl_scan.c:366: error: passing argument 3 of 'spa_event_notify' from incompatible pointer type

../../common/fs/zfs/dsl_scan.c:366: error: too few arguments to function 'spa_event_notify'

../../common/fs/zfs/dsl_scan.c:421: error: passing argument 3 of 'spa_event_notify' from incompatible pointer type

../../common/fs/zfs/dsl_scan.c:421: error: too few arguments to function 'spa_event_notify'

../../common/fs/zfs/dsl_scan.c:1992: error: passing argument 3 of 'spa_event_notify' from incompatible pointer type

../../common/fs/zfs/dsl_scan.c:1992: error: too few arguments to function 'spa_event_notify'

@kithrup
Copy link
Author

kithrup commented Dec 21, 2017

I've pushed it to my branch; does the PR automatically pick it up?

@ahrens
Copy link
Member

ahrens commented Dec 21, 2017

@kithrup Yep. The new batch of automated build/tests are running now.

@kithrup
Copy link
Author

kithrup commented Dec 21, 2017

I saw that just after I commented. yay automation testing!

@prakashsurya
Copy link
Member

@ahrens looks like the compilation errors have been fixed; could you give this another look when you have time?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants