-
Notifications
You must be signed in to change notification settings - Fork 69
Add notifications when a scrub is paused or resumed. #495
Conversation
Notification when scrub is aborted taken from FreeBSD. The change has been tested on FreeNAS.
@@ -203,6 +203,9 @@ extern "C" { | |||
#define ESC_ZFS_CONFIG_SYNC "ESC_ZFS_config_sync" | |||
#define ESC_ZFS_SCRUB_START "ESC_ZFS_scrub_start" | |||
#define ESC_ZFS_SCRUB_FINISH "ESC_ZFS_scrub_finish" | |||
#define ESC_ZFS_SCRUB_ABORT ""ESC_ZFS_scrub_abort" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there's a typo here (two ""
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blast it. I thought I'd made that by patching. Hold on a bit while I fix it. grumble.
Thanks Matt.
You'll need to fix the compilation errors, which you can see by clicking "Details" next to the failed check:
|
I've pushed it to my branch; does the PR automatically pick it up? |
@kithrup Yep. The new batch of automated build/tests are running now. |
I saw that just after I commented. yay automation testing! |
@ahrens looks like the compilation errors have been fixed; could you give this another look when you have time? |
Notification when scrub is aborted taken from FreeBSD, the other two were modeled on that.
The change has been tested on FreeNAS.