This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed by: George Wilson george.wilson@delphix.com
Reviewed by: Pavel Zakharov pavel.zakharov@delphix.com
In usr/src/uts/common/disp/cpupart.c, cpupart_create() allocates a buffer and assigns it to the
cp_lgrploads member of a cpupart_t struct:
pp->cp_nlgrploads = lgrp_plat_max_lgrps();
pp->cp_lgrploads = kmem_zalloc(sizeof (lpl_t) * pp->cp_nlgrploads,
KM_SLEEP);
The function then goes on to call cpupart_lpl_initialize(), which allocates an identical buffer and
assigns it to the same field, leaking the original buffer:
sz = cp->cp_nlgrploads = lgrp_plat_max_lgrps();
cp->cp_lgrploads = kmem_zalloc(sizeof (lpl_t) * sz, KM_SLEEP);
We should be able to just remove the initial allocation.
Upstream bug: DLPX-56280