Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

zfs/spl 0.6.5.3 build fails for linux-4.3 when configured as built-in modules #498

Closed
gedia opened this issue Nov 11, 2015 · 7 comments
Closed

Comments

@gedia
Copy link

gedia commented Nov 11, 2015

It seems that building a 4.3 kernel with spl and zfs-kmod built-in fails. They build fine as modules. Linux-4.2.3 is not affected by this. I'm attaching a build log here as well as my kernel configuration.

GCC version is: gcc (Gentoo 5.2.0 p1.1, pie-0.6.4) 5.2.0
build-log.txt
config.txt

@gedia gedia changed the title zfs/spl build fails for linux-4.3 when configured as built-in modules zfs/spl 0.6.5.3 build fails for linux-4.3 when configured as built-in modules Nov 11, 2015
@behlendorf
Copy link
Contributor

Just taking a quick look it's not clear to me that it built any of the spl. Since the errors are all about missing spl symbols that would make sense.

@hunbalazs
Copy link

@behlendorf it didnt, it seems that (for some reason) it only builds ZFS but not SPL

# grep CONFIG_SPL .config
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_SPL=y

it works with kernel 4.2.6
(gcc version 4.9.3 (Gentoo 4.9.3 p1.1, pie-0.6.2))

@sergiall
Copy link

sergiall commented Dec 1, 2015

It works with kernel 4.2.6 (gcc version 5.2.1 Debian stretch/sid,Ubuntu 15.10/16.04.
Both SPL & ZFS build ok and work fine,but for linux 4.3 it still fail for build :( .

behlendorf added a commit to behlendorf/spl that referenced this issue Dec 2, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#481
Issue openzfs#498
behlendorf added a commit to behlendorf/zfs that referenced this issue Dec 2, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Requires-spl: refs/pull/503/head
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
@behlendorf
Copy link
Contributor

@sergiall @hunbalazs I've proposed two patches to fix this. Any additional testing would be appreciated, I've verified the fix with v4.4-rc3 but it should fix all kernels.

@hunbalazs
Copy link

Kernel built and running.
Thank you very much @behlendorf .

behlendorf added a commit that referenced this issue Dec 2, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #481
Issue #498
behlendorf added a commit to behlendorf/zfs that referenced this issue Dec 2, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
@behlendorf
Copy link
Contributor

@hunbalazs thanks, this has been merged to master and will appear in the next point release.

4e6f996 Fix --enable-linux-builtin

@sergiall
Copy link

sergiall commented Dec 2, 2015

Wow! Thank you very much @behlendorf !

ryao pushed a commit to ryao/spl that referenced this issue Dec 3, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#481
Issue openzfs#498
ryao pushed a commit to ryao/zfs that referenced this issue Dec 3, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
goulvenriou pushed a commit to Alyseo/zfs that referenced this issue Dec 8, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
behlendorf added a commit that referenced this issue Dec 24, 2015
Adding VPATH support, commit 37d7cd9, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

The code which adds the `spl/` directory to the top level
Makefile was failing due to the addition of the `certs/` path.
The search pattern has been adjusted to be more tolerant.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #481
Issue #498
behlendorf added a commit to openzfs/zfs that referenced this issue Dec 24, 2015
Adding VPATH support, commit 47a4a6f, required that a `src`
and `obj` line be added to the top of the Makefiles.  They
must be removed from the Makefiles when builtin.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs/spl#481
Issue openzfs/spl#498
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants