This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Illumos taskq port #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
943 zio_interrupt ends up calling taskq_dispatch with TQ_SLEEP Reviewed by: Albert Lee <trisk@nexenta.com> Reviewed by: Richard Lowe <richlowe@richlowe.net> Reviewed by: Alexey Zaytsev <alexey.zaytsev@nexenta.com> Reviewed by: Jason Brian King <jason.brian.king@gmail.com> Reviewed by: George Wilson <gwilson@zfsmail.com> Reviewed by: Adam Leventhal <ahl@delphix.com> Approved by: Gordon Ross <gwr@nexenta.com>
The spl_task structure was moved into the taskq.h file and was renamed to taskq_ent. This was to align with the naming convention which the ZFS code assumes (i.e. ZFS assumes this structure to be named taskq_ent).
Preallocated tasks should never make it onto the free list of tasks. Thus, if an element removed from the free list is found to have it's TQENT_FLAG_PREALLOC flag set, it is reported as an ASSERT.
Although the __taskq_dispatch function is kind enough to zero out the tqent_flags variable when it gets called, this variable should probably get zeroed out by the taskq_alloc function as well.
|
Ok, I think this is ready to be reviewed and merged if everything checks out. I still need to get a regression test written for the new interface though. Not sure if you want this included when this lands, or if that can go in separately? |
|
Thanks for breaking these all up in to separate patches, but in this case I think it makes sense to squash them all in to one. The test case can be done with a follow up path, let just make sure we don't forget to do it. Additional comments inline. |
|
I incorporated your feedback and pushed it all to another branch (illumos-taskq-port2). I'm going to close this pull request and open another one for the updated branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently running down a kernel crash when insmod'ing zfs with the illumos-taskq-port patched zfs and spl packages.. But I thought I'd send this up for you to look over in the meantime.
BTW.. Here's the bt from crash on the dump. I think it's due to a NULL pointer dereference.
crash> bt PID: 8354 TASK: ffff880116689540 CPU: 1 COMMAND: "insmod" #0 [ffff8801169638a0] machine_kexec at ffffffff810312bb #1 [ffff880116963900] crash_kexec at ffffffff810b6742 #2 [ffff8801169639d0] oops_end at ffffffff814df070 #3 [ffff880116963a00] die at ffffffff8100f2eb #4 [ffff880116963a30] do_trap at ffffffff814de964 #5 [ffff880116963a90] do_invalid_op at ffffffff8100ceb5 #6 [ffff880116963b30] invalid_op at ffffffff8100bf5b [exception RIP: kfree+666] RIP: ffffffff8115c4da RSP: ffff880116963be8 RFLAGS: 00010046 RAX: ffffea0003d400a8 RBX: ffff880118003af0 RCX: ffff880118003708 RDX: 0040000000000000 RSI: 0000000000000038 RDI: ffff880118003af0 RBP: ffff880116963c48 R8: ffff880116963bd0 R9: 0000000000000001 R10: 00000000ffffffff R11: 0000000000000000 R12: ffffffffa01c3616 R13: 0000000000000082 R14: 0000000000000008 R15: 0000000000000000 ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018 #7 [ffff880116963c50] kmem_free_debug at ffffffffa01c3616 [spl] #8 [ffff880116963c60] __taskq_destroy at ffffffffa01c4705 [spl] #9 [ffff880116963c90] spa_deactivate at ffffffffa064e4a0 [zfs] #10 [ffff880116963cc0] spa_open_common at ffffffffa06562e7 [zfs] #11 [ffff880116963d30] spa_open at ffffffffa06564b3 [zfs] #12 [ffff880116963d40] dsl_dir_open_spa at ffffffffa063c1b3 [zfs] #13 [ffff880116963de0] dmu_objset_find_spa at ffffffffa061d346 [zfs] #14 [ffff880116963eb0] zvol_create_minors at ffffffffa06a8181 [zfs] #15 [ffff880116963ed0] zvol_init at ffffffffa06a82a1 [zfs] #16 [ffff880116963ef0] _init at ffffffffa0682b82 [zfs] #17 [ffff880116963f10] init_module at ffffffffa0682c93 [zfs] #18 [ffff880116963f20] do_one_initcall at ffffffff8100204c #19 [ffff880116963f50] sys_init_module at ffffffff810ace2f #20 [ffff880116963f80] system_call_fastpath at ffffffff8100b172 RIP: 00000036b82e5dea RSP: 00007fffd3566ec8 RFLAGS: 00000217 RAX: 00000000000000af RBX: ffffffff8100b172 RCX: 00000036b82e5f3a RDX: 00000000020b4010 RSI: 0000000001684835 RDI: 00007f37dcfeb010 RBP: 00000000020b4010 R8: 0000000002001000 R9: 0000000001001000 R10: 00000036b82d8460 R11: 0000000000000202 R12: 0000000002000000 R13: 0000000001684835 R14: 00007fffd3568837 R15: 0000000001684835 ORIG_RAX: 00000000000000af CS: 0033 SS: 002b