Skip to content

Commit

Permalink
Add bash completions by Aneurin Price.
Browse files Browse the repository at this point in the history 
These can be manually installed as needed by end users.  They
have been added to the repository so they can be kept up to date
with the latest code.

Signed-off-by: Turbo Fredriksson <turbo@bayour.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1588
  • Loading branch information
@FransUrbo @behlendorf
FransUrbo authored and behlendorf committed Aug 6, 2014
1 parent 5dbd68a commit 1ffe90c
Show file tree
Hide file tree
Showing 5 changed files with 401 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile.am
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ include $(top_srcdir)/config/tgz.am

SUBDIRS = include rpm
if CONFIG_USER
SUBDIRS += dracut udev etc man scripts lib cmd
SUBDIRS += dracut udev etc man scripts lib cmd contrib
endif
if CONFIG_KERNEL
SUBDIRS += module
Expand Down
2 changes: 2 additions & 0 deletions configure.ac
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ AC_CONFIG_FILES([
cmd/arcstat/Makefile
cmd/dbufstat/Makefile
cmd/zed/Makefile
contrib/Makefile
contrib/bash_completion.d/Makefile
module/Makefile
module/avl/Makefile
module/nvpair/Makefile
Expand Down
2 changes: 2 additions & 0 deletions contrib/Makefile.am
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
SUBDIRS = bash_completion.d
DIST_SUBDIRS = bash_completion.d
5 changes: 5 additions & 0 deletions contrib/bash_completion.d/Makefile.am
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
bashcompletiondir = $(sysconfdir)/bash_completion.d

noinst_DATA = zfs

EXTRA_DIST = $(noinst_DATA)

3 comments on commit 1ffe90c

@mailinglists35
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be kept in sync with https://github.com/Aneurin/zfs-bash ?

@behlendorf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice. @Aneurin can I talk you in to opening a pull requests against zfsonlinux/zfs with your updated bash completions?

@Aneurin
Copy link

@Aneurin Aneurin commented on 1ffe90c Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect you probably can. I've changed the way snapshot names are suggested though, so I'm first going to see if I can get anyone on the mailing list to try it out...

Please sign in to comment.