Skip to content

Commit

Permalink
Remove obsolete_counts from grub2 compatibility list
Browse files Browse the repository at this point in the history
PR#15459 add all read-only compatible zpool features to grub2
compatibility list. 'obsolete_counts' is a read-only features that
depends on 'device_removal' feature which is not read-only and
is marked as ZFEATURE_FLAG_MOS. Creating a pool with grub2
compatibility enables 'device_removal' feature as well, which is
not desired.

This commit removes the 'obsolete_counts' feature from
grub2 compatibility list, as GRUB only supports read-only
compatible features.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes #15499
  • Loading branch information
usaleem-ix committed Nov 7, 2023
1 parent 020f6fd commit 78ac868
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion cmd/zpool/compatibility.d/grub2
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ large_blocks
livelist
log_spacemap
lz4_compress
obsolete_counts
project_quota
resilver_defer
spacemap_histogram
Expand Down

0 comments on commit 78ac868

Please sign in to comment.