Skip to content

Commit

Permalink
Revert "Use directory xattrs for symlinks"
Browse files Browse the repository at this point in the history
This reverts commit 6a7c0cc.

A proper fix for Issue #1648 was landed under Issue #1890, so this is no
longer needed.

Signed-off-by: Ned Bass <bass6@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1648
  • Loading branch information
nedbass authored and behlendorf committed Dec 10, 2013
1 parent 472e7c6 commit b6e335b
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions module/zfs/zpl_xattr.c
Expand Up @@ -446,10 +446,6 @@ zpl_xattr_set_sa(struct inode *ip, const char *name, const void *value,
if (error == -ENOENT)
error = zpl_xattr_set_dir(ip, name, NULL, 0, flags, cr);
} else {
/* Do not allow SA xattrs in symlinks (issue #1648) */
if (S_ISLNK(ip->i_mode))
return (-EMLINK);

/* Limited to 32k to keep nvpair memory allocations small */
if (size > DXATTR_MAX_ENTRY_SIZE)
return (-EFBIG);
Expand Down

0 comments on commit b6e335b

Please sign in to comment.