Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sanjeevbagewadinutanix committed Aug 10, 2017
1 parent f63b79e commit ca29e4f
Showing 1 changed file with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions module/zfs/zio.c
Expand Up @@ -3661,18 +3661,8 @@ zio_dva_throttle_done(zio_t *zio)
ASSERT3U(zio->io_child_type, ==, ZIO_CHILD_VDEV);
ASSERT(vd != NULL);
ASSERT3P(vd, ==, vd->vdev_top);
/*
* If fault injection is enabled, the ZIO_FLAG_IO_RETRY could be set by
* zio_handle_device_injection() to generate the FMA events and update
* stats. Hence, ignore the flag and process such zios.
*
* A better fix would be to add another flag in the zio_t to indicate
* that the zio is failed because of a zinject rule. Considering the
* fact that we do this in debug bits, we could do with the crude check
* of zio_injection_enabled.
*/
ASSERT(zio_injection_enabled || !(zio->io_flags & ZIO_FLAG_IO_RETRY));
ASSERT(!(zio->io_flags & (ZIO_FLAG_IO_REPAIR | ZIO_FLAG_IO_RETRY)));
ASSERT(!(zio->io_flags & ZIO_FLAG_IO_REPAIR));
ASSERT(zio->io_flags & ZIO_FLAG_IO_ALLOCATING);
ASSERT(!(lio->io_flags & ZIO_FLAG_IO_REWRITE));
ASSERT(!(lio->io_orig_flags & ZIO_FLAG_NODATA));
Expand Down

0 comments on commit ca29e4f

Please sign in to comment.