Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vdev_id support to zfs-initramfs #1183

Closed
nedbass opened this issue Jan 8, 2013 · 8 comments
Closed

add vdev_id support to zfs-initramfs #1183

nedbass opened this issue Jan 8, 2013 · 8 comments
Assignees
Labels
Type: Feature Feature request or new feature
Milestone

Comments

@nedbass
Copy link
Contributor

nedbass commented Jan 8, 2013

Before we deprecate zpool_id we need to provide a migration path for root-on-ZFS users. To that end vdev_id must be intetgrated with zfs-initramfs so that a root pool using /dev/disk/by-vdev names will be properly imported.
#981

@ghost ghost assigned nedbass Jan 9, 2013
@ryao
Copy link
Contributor

ryao commented Jan 15, 2013

Is zfs-initramfs part of ZFSOnLinux upstream? I thought that this was handled at the distribution level.

@nedbass
Copy link
Contributor Author

nedbass commented Jan 15, 2013

You're right, zfs-initramfs is not part of ZOL. I just wanted to make sure this is coordinated with downstream maintainers before we remove zpool_id.

@dajhorn
Copy link
Contributor

dajhorn commented Jan 15, 2013

@nedbass, pkg-zfs got this change from #811 and it was published as 0.6.0.83.

@ryao
Copy link
Contributor

ryao commented Jan 15, 2013

@nedbass Thanks for your concern. Gentoo's genkernel software uses mdev, so none of the functionality that depends upon udev helpers currently works. The gentoo bug tracker has no requests for it. Removing zpool_id will not cause any regressions in downstream Gentoo.

@nedbass
Copy link
Contributor Author

nedbass commented Jan 15, 2013

@dajhorn It looks like pkg-zfs integrated support for zpool_id but not for vdev_id. Per #981 we are interested in retiring zpool_id in favor of vdev_id.

@dajhorn
Copy link
Contributor

dajhorn commented Jan 15, 2013

@nedbass, okay, right. I will add 69-vdev.rules and vdev_id to the manifest.

@behlendorf
Copy link
Contributor

Thanks @nedbass @ryao @dajhorn. Since we'll be dropping the zpool_id bits in -rc14 we'll want to make sure the FAQ gets updated accordingly so people using the legacy scripts can easily migrate to the improved vdev_id scripts.

dajhorn added a commit to zfsonlinux/pkg-zfs that referenced this issue Jan 24, 2013
The `/lib/udev/vdev_id` helper is superceding the `/lib/udev/zpool_id` helper,
which is deprecated and will be soon removed upstream. openzfs/zfs#1183
@behlendorf
Copy link
Contributor

Closing, I've just retired zpool_id/zpool_layout and @dajhorn has updated the initramfs.

dbf763b Retire zpool_id infrastructure
dajhorn/pkg-zfs@bccc23f Add the vdev_id udev helper to the initramfs hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Feature request or new feature
Projects
None yet
Development

No branches or pull requests

4 participants