Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrinker replacements for 6.7+ #15582

Open
RaitoBezarius opened this issue Nov 26, 2023 · 6 comments
Open

shrinker replacements for 6.7+ #15582

RaitoBezarius opened this issue Nov 26, 2023 · 6 comments
Labels
Type: Feature Feature request or new feature

Comments

@RaitoBezarius
Copy link
Contributor

Describe the feature would like to see added to OpenZFS

In Linux 6.7, the shrinker APIs are all GPL-only symbols (shrinker_register, shrinker_alloc, shrinker_free).
It is not clear to me what is the way forward, except by rebuilding this set of APIs.

How will this feature improve OpenZFS?

ARC compatibility with the memory management unit of Linux in 6.7+.

Additional context

Introducing commit: f2383e01507eeee8a1c1283d61a117a97d6c4ebe.

@RaitoBezarius RaitoBezarius added the Type: Feature Feature request or new feature label Nov 26, 2023
@snajpa
Copy link
Contributor

snajpa commented Nov 28, 2023

Is there any reason why this can't be wrapped by a set of new SPL functions? (I don't think I understand what the issue is, this seems like an obvious solution to me?)

@RaitoBezarius
Copy link
Contributor Author

What function do you wrap from the kernel? There's no non-GPL-only entrypoints anymore, is there?

@Vlad1mir-D
Copy link

But SPL is GPL.

@RaitoBezarius
Copy link
Contributor Author

Missed this obvious thing :). I am writing an SPL wrapper for it, it's a bit tedious because the new API require dynamic allocations and the whole thing was operating under assumption this is part of the object global variable space.

@ryao
Copy link
Contributor

ryao commented Dec 14, 2023

But SPL is GPL.

Historically, we do not do this. Oracle got in trouble for doing this.

@ryao
Copy link
Contributor

ryao commented Dec 14, 2023

I sent an email to the author asking him to change the symbol exports to EXPORT_SYMBOL(). Hopefully, he will agree.

@robn robn mentioned this issue Dec 16, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Feature request or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants