Null pointer dereference at arc_read #2171
Comments
|
This looks like the same bug as #2165. edit: call paths up to dbuf_read differ, so looks like we can arrive at the same bug via different routes. |
|
Yes, it looks very likely that this is the same as Illumos 4089. The NULL dereference occurred in basically that same chunk of code. If you still have the zfs.ko module from the failure and it has debugging symbols we could get the exact line to confirm this. Regardless we should pick up the upstream fix, I'll open a pull request. |
4089 NULL pointer dereference in arc_read() Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@nexenta.com> References: https://www.illumos.org/issues/4089 illumos/illumos-gate@57815f6 Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#2171
|
Unfortunately I don't have debug symbols in the module (issue #2173). Thanks for making the pull request! I don't think I can verify the fix, because I don't have an easy reproducer. |
|
I think we hit this doing torture tests on Ubuntu 12.04 with Linux 3.2 kernel and ZFS 0.6.2. Unfortunately I don't have the module built with debug symbols either. :( |
4089 NULL pointer dereference in arc_read() Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@nexenta.com> References: https://www.illumos.org/issues/4089 illumos/illumos-gate@57815f6 Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue #2171 Issue #2165 Closes #2198
|
@josephglanville The expected fix has been merged to master. It would be helpful if you could verify you're unable to recreate the issue using the latest source from Github. |
|
@behlendorf I have gotten master installed. This takes about 24-48hrs to reproduce under load, will let you know how it goes. |
|
I had some other issues with master so I backported the patch to 0.6.2. |
4089 NULL pointer dereference in arc_read() Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Saso Kiselkov <skiselkov.ml@gmail.com> Reviewed by: Garrett D'Amore <garrett@damore.org> Approved by: Dan McDonald <danmcd@nexenta.com> References: https://www.illumos.org/issues/4089 illumos/illumos-gate@57815f6 Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#2171 Issue openzfs#2165 Closes openzfs#2198 Conflicts: module/zfs/arc.c
|
Hi @josephglanville Thanks |
|
@tuxoko I think I did apply the patch correctly but it didn't fix the problem. However I then applied all the patches in @ryao's ZFS fork here: https://github.com/ryao/zfs/tree/zfs-0.6.2-r4 and that fixed my problems. I haven't had time to bisect and find out exactly which other patch fixed the problem but I suspect it was ryao@74db5bf |
|
Just for reference the patch you referenced has been merged to master. |
|
Did the patch merged to master resolve this issue for everyone? |
|
Since we've now merged the patches referenced above in to master which fixed the issue I'm going to close this issue. |
I hit this one today. It's Debian stock 3.2.0-4-amd64 kernel with ZoL 0.6.2 from the ZoL Debian packages. The machine has 64GB of ECC RAM and ZFS is loaded with default options. This zpool has 3x 6-disk raidz2 with 2x 240GB L2ARC SSDs.
The server runs BackupPC (rsync) and Netatalk for Apple Time Machine. It also sends and receives streams from other ZFS machines. Many of these things were going on at the time of the crash.
This host has been running without problems for quite some time. I don't think it will be easy for me to reproduce it.
Could this be https://www.illumos.org/issues/4089 ?
The text was updated successfully, but these errors were encountered: