Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case: mmp_on_uberblocks #6407

Closed
dinatale2 opened this issue Jul 26, 2017 · 0 comments
Closed

Test case: mmp_on_uberblocks #6407

dinatale2 opened this issue Jul 26, 2017 · 0 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@dinatale2
Copy link
Contributor

System information

Type Version/Name
Distribution Name All
Distribution Version All
Linux Kernel All
Architecture All
ZFS Version 0.7.0-rc5
SPL Version 0.7.0-rc5

Describe the problem you're observing

Occasionally, mmp_on_uberblocks will fail. The test attempts to count the number of times uberblocks change in a pool and does so with a loop. It is possible the test is missing uberblock changes or the "fudge factor" for the number of changes may be incorrect.

Describe how to reproduce the problem

Reproducible by buildbot.

Include any warning/errors/backtraces from the system logs

http://build.zfsonlinux.org/builders/CentOS%207.1%20x86_64%20%28TEST%29/builds/6437/steps/shell_8/logs/log

Test: /usr/share/zfs/zfs-tests/tests/functional/mmp/mmp_on_uberblocks (run as root) [00:12] [FAIL]
10:18:14.74 ASSERTION: Ensure MMP uberblocks update at the correct interval
10:18:14.76 SUCCESS: set_tunable64 zfs_txg_timeout 5000
10:18:14.79 SUCCESS: mmp_set_hostid 01234567
10:18:14.79 NOTE: begin default_setup_noexit
10:18:15.01 SUCCESS: zpool create -f testpool loop0
10:18:15.13 SUCCESS: zfs create testpool/testfs
10:18:15.25 SUCCESS: zfs set mountpoint=/var/tmp/testdir testpool/testfs
10:18:15.32 SUCCESS: zpool set multihost=on testpool
10:18:18.11 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:18.095243468 +0000
10:18:18.11 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:16.684227075 +0000
10:18:18.11 @@ -4,8 +4,8 @@
10:18:18.11  	version = 5000
10:18:18.11  	txg = 10
10:18:18.11  	guid_sum = 942101074730757650
10:18:18.11 -	timestamp = 1501064296 UTC = Wed Jul 26 10:18:16 2017
10:18:18.11 +	timestamp = 1501064295 UTC = Wed Jul 26 10:18:15 2017
10:18:18.11  	mmp_magic = 00000000a11cea11
10:18:18.11 -	mmp_delay = 992188604
10:18:18.11 +	mmp_delay = 1000000000
10:18:18.11  
10:18:18.11  SUCCESS: zdb -u testpool
10:18:18.15 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:19.69 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:19.688261976 +0000
10:18:19.69 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:18.095243468 +0000
10:18:19.69 @@ -4,8 +4,8 @@
10:18:19.69  	version = 5000
10:18:19.69  	txg = 10
10:18:19.69  	guid_sum = 942101074730757650
10:18:19.69 -	timestamp = 1501064297 UTC = Wed Jul 26 10:18:17 2017
10:18:19.69 +	timestamp = 1501064296 UTC = Wed Jul 26 10:18:16 2017
10:18:19.69  	mmp_magic = 00000000a11cea11
10:18:19.69 -	mmp_delay = 999106611
10:18:19.69 +	mmp_delay = 992188604
10:18:19.69  
10:18:19.69  SUCCESS: zdb -u testpool
10:18:19.73 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:21.11 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:21.093278299 +0000
10:18:21.11 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:19.688261976 +0000
10:18:21.11 @@ -4,8 +4,8 @@
10:18:21.11  	version = 5000
10:18:21.11  	txg = 10
10:18:21.11  	guid_sum = 942101074730757650
10:18:21.11 -	timestamp = 1501064299 UTC = Wed Jul 26 10:18:19 2017
10:18:21.11 +	timestamp = 1501064297 UTC = Wed Jul 26 10:18:17 2017
10:18:21.11  	mmp_magic = 00000000a11cea11
10:18:21.11 -	mmp_delay = 1007973028
10:18:21.11 +	mmp_delay = 999106611
10:18:21.11  
10:18:21.11  SUCCESS: zdb -u testpool
10:18:21.13 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:22.54 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:22.540295110 +0000
10:18:22.54 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:21.093278299 +0000
10:18:22.54 @@ -4,8 +4,8 @@
10:18:22.54  	version = 5000
10:18:22.54  	txg = 10
10:18:22.54  	guid_sum = 942101074730757650
10:18:22.54 -	timestamp = 1501064300 UTC = Wed Jul 26 10:18:20 2017
10:18:22.54 +	timestamp = 1501064299 UTC = Wed Jul 26 10:18:19 2017
10:18:22.54  	mmp_magic = 00000000a11cea11
10:18:22.54 -	mmp_delay = 1007969066
10:18:22.54 +	mmp_delay = 1007973028
10:18:22.54  
10:18:22.54  SUCCESS: zdb -u testpool
10:18:22.56 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:23.99 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:23.981311852 +0000
10:18:23.99 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:22.540295110 +0000
10:18:23.99 @@ -4,8 +4,8 @@
10:18:23.99  	version = 5000
10:18:23.99  	txg = 10
10:18:23.99  	guid_sum = 942101074730757650
10:18:23.99 -	timestamp = 1501064301 UTC = Wed Jul 26 10:18:21 2017
10:18:23.99 +	timestamp = 1501064300 UTC = Wed Jul 26 10:18:20 2017
10:18:23.99  	mmp_magic = 00000000a11cea11
10:18:23.99 -	mmp_delay = 1030408037
10:18:23.99 +	mmp_delay = 1007969066
10:18:23.99  
10:18:23.99  SUCCESS: zdb -u testpool
10:18:24.01 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:25.48 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:25.467329116 +0000
10:18:25.48 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:23.981311852 +0000
10:18:25.48 @@ -4,8 +4,8 @@
10:18:25.48  	version = 5000
10:18:25.48  	txg = 10
10:18:25.48  	guid_sum = 942101074730757650
10:18:25.48 -	timestamp = 1501064303 UTC = Wed Jul 26 10:18:23 2017
10:18:25.48 +	timestamp = 1501064301 UTC = Wed Jul 26 10:18:21 2017
10:18:25.48  	mmp_magic = 00000000a11cea11
10:18:25.48 -	mmp_delay = 1029927819
10:18:25.48 +	mmp_delay = 1030408037
10:18:25.48  
10:18:25.48  SUCCESS: zdb -u testpool
10:18:25.51 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:26.88 --- /var/tmp/mmp-uber-curr.txt	2017-07-26 10:18:26.876345486 +0000
10:18:26.88 +++ /var/tmp/mmp-uber-prev.txt	2017-07-26 10:18:25.467329116 +0000
10:18:26.88 @@ -4,8 +4,8 @@
10:18:26.88  	version = 5000
10:18:26.88  	txg = 10
10:18:26.88  	guid_sum = 942101074730757650
10:18:26.88 -	timestamp = 1501064304 UTC = Wed Jul 26 10:18:24 2017
10:18:26.88 +	timestamp = 1501064303 UTC = Wed Jul 26 10:18:23 2017
10:18:26.88  	mmp_magic = 00000000a11cea11
10:18:26.88 -	mmp_delay = 1029693950
10:18:26.88 +	mmp_delay = 1029927819
10:18:26.88  
10:18:26.88  SUCCESS: zdb -u testpool
10:18:26.92 SUCCESS: mv /var/tmp/mmp-uber-curr.txt /var/tmp/mmp-uber-prev.txt
10:18:26.92 NOTE: Uberblock changed 7 times
10:18:26.92 Fewer uberblock writes occured than expected (10)
@dinatale2 dinatale2 added the Component: Test Suite Indicates an issue with the test framework or a test case label Jul 26, 2017
@dinatale2 dinatale2 mentioned this issue Jul 28, 2017
Merged
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Aug 1, 2017
@dinatale2 @tonyhutter
mmp_on_uberblocks: Use kstat for uberblock counts
89f3625 
Use kstat to get a more accurate count of uberblock updates.
Using a loop with zdb can potentially miss some uberblocks.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#6407
Closes openzfs#6419
tonyhutter pushed a commit that referenced this issue Aug 2, 2017
@dinatale2 @tonyhutter
mmp_on_uberblocks: Use kstat for uberblock counts
12acabe 
Use kstat to get a more accurate count of uberblock updates.
Using a loop with zdb can potentially miss some uberblocks.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes #6407
Closes #6419
Fabian-Gruenbichler pushed a commit to Fabian-Gruenbichler/zfs that referenced this issue Sep 6, 2017
@dinatale2 @Fabian-Gruenbichler
mmp_on_uberblocks: Use kstat for uberblock counts
36c2c8f 
Use kstat to get a more accurate count of uberblock updates.
Using a loop with zdb can potentially miss some uberblocks.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes openzfs#6407
Closes openzfs#6419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dinatale2