Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case: events_002_pos #6486

Closed
dinatale2 opened this issue Aug 9, 2017 · 0 comments
Closed

Test case: events_002_pos #6486

dinatale2 opened this issue Aug 9, 2017 · 0 comments
Labels
Component: Test Suite Indicates an issue with the test framework or a test case

Comments

@dinatale2
Copy link
Contributor

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 16.04 and 17.04
Linux Kernel All
Architecture All
ZFS Version 0.7.0
SPL Version 0.7.0

Describe the problem you're observing

Occasionally events_002_pos will fail. I suspect that the testcase may not sleep long enough for the zed to process all its missed events which may explain the sporadic nature of the failure.

Describe how to reproduce the problem

Buildbot Ubuntu TEST builders.

Include any warning/errors/backtraces from the system logs

http://build.zfsonlinux.org/builders/Ubuntu%2016.04%20x86_64%20Kmemleak%20%28TEST%29/builds/2862/steps/shell_8/logs/log

Test: /usr/share/zfs/zfs-tests/tests/functional/events/events_002_pos (run as root) [00:05] [FAIL]
03:24:48.10 ASSERTION: Verify ZED handles missed events on when starting
03:24:48.11 SUCCESS: truncate -s 268435456 /var/tmp/vdev1 /var/tmp/vdev2
03:24:48.12 SUCCESS: cp -f /var/tmp/zed/zed.debug.log /var/tmp/zed/zed.debug.log.old
03:24:48.36 SUCCESS: zpool create mpool.16596 mirror /var/tmp/vdev1 /var/tmp/vdev2
03:24:48.42 NOTE: Starting ZED
03:24:48.44 SUCCESS: eval zed -vF -d /var/tmp/zed -p /var/tmp/zed/zed.pid -s /var/tmp/zed/state 2>/var/tmp/zed/zedlog &
03:24:48.45 SUCCESS: zed_start
03:24:49.46 SUCCESS: sleep 1
03:24:49.49 SUCCESS: grep -q ^ZEVENT_POOL=mpool.16596 /tmp/tmp_event_zed.16596
03:24:49.49 NOTE: Stopping ZED
03:24:49.50 SUCCESS: kill 16786
03:24:49.51 SUCCESS: cp -f /var/tmp/zed/zed.debug.log /var/tmp/zed/zed.debug.log.old
03:24:49.58 SUCCESS: zpool offline mpool.16596 /var/tmp/vdev1
03:24:49.83 SUCCESS: zpool online mpool.16596 /var/tmp/vdev1
03:24:49.98 SUCCESS: zpool scrub mpool.16596
03:24:50.05 NOTE: Starting ZED
03:24:50.06 SUCCESS: eval zed -vF -d /var/tmp/zed -p /var/tmp/zed/zed.pid -s /var/tmp/zed/state 2>/var/tmp/zed/zedlog &
03:24:50.08 SUCCESS: zed_start
03:24:53.13 SUCCESS: sleep 3
03:24:53.14 SUCCESS: grep -q sysevent.fs.zfs.pool_create /tmp/tmp_events_zed.16596 exited 1
03:24:53.15 
03:24:53.15 ERROR: grep -q sysevent.fs.zfs.vdev_online /tmp/tmp_events_zed.16596 exited 1
03:24:53.15 NOTE: Performing test-fail callback (/usr/share/zfs/zfs-tests/callbacks/zfs_dbgmsg.ksh)
@dinatale2 dinatale2 added the Component: Test Suite Indicates an issue with the test framework or a test case label Aug 9, 2017
@Nasf-Fan Nasf-Fan mentioned this issue Aug 10, 2017
Merged
13 tasks
behlendorf added a commit to behlendorf/zfs that referenced this issue Oct 19, 2017
@behlendorf
Emit history events for 'zpool create'
bd54e0d 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Additionally, split the pool_destroy event in to pool_destroy
and pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#6486
behlendorf added a commit to behlendorf/zfs that referenced this issue Oct 20, 2017
@behlendorf
Emit history events for 'zpool create'
5555c72 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

NOTE: Custom event runfile added to verify reliability.
      This will be removed in the final merge.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#6486
behlendorf added a commit to behlendorf/zfs that referenced this issue Oct 20, 2017
@behlendorf
Emit history events for 'zpool create'
2ef74db 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

NOTE: Custom event runfile added to verify reliability.
      This will be removed in the final merge.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#6486
behlendorf added a commit to behlendorf/zfs that referenced this issue Oct 20, 2017
@behlendorf
Emit history events for 'zpool create'
b568627 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

NOTE: Custom event runfile added to verify reliability.
      This will be removed in the final merge.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#6486
behlendorf added a commit to behlendorf/zfs that referenced this issue Oct 20, 2017
@behlendorf
Emit history events for 'zpool create'
8077ea8 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

NOTE: Custom event runfile added to verify reliability.
      This will be removed in the final merge.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#6486
behlendorf added a commit to behlendorf/zfs that referenced this issue Oct 20, 2017
@behlendorf
Emit history events for 'zpool create'
855fc85 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

NOTE: Custom event runfile added to verify reliability.
      This will be removed in the final merge.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#6486
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Nov 4, 2017
@behlendorf @Nasf-Fan
Emit history events for 'zpool create'
3561fda 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Nov 6, 2017
@behlendorf @Nasf-Fan
Emit history events for 'zpool create'
7333f35 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
behlendorf added a commit to tonyhutter/zfs that referenced this issue Nov 28, 2017
@behlendorf
Emit history events for 'zpool create'
1ad9238 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
behlendorf added a commit to tonyhutter/zfs that referenced this issue Dec 1, 2017
@behlendorf
Emit history events for 'zpool create'
5c8eaf1 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
tonyhutter pushed a commit that referenced this issue Dec 5, 2017
@behlendorf @tonyhutter
Emit history events for 'zpool create'
954516c 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #6712
Closes #6486
Conflicts:
	tests/zfs-tests/tests/functional/events/events_002_pos.ksh
tonyhutter pushed a commit to tonyhutter/zfs that referenced this issue Dec 5, 2017
@behlendorf @tonyhutter
Emit history events for 'zpool create'
f473d64 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
Conflicts:
	tests/zfs-tests/tests/functional/events/events_002_pos.ksh
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Jan 29, 2018
@behlendorf @Nasf-Fan
Emit history events for 'zpool create'
a3ad9e6 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
Nasf-Fan pushed a commit to Nasf-Fan/zfs that referenced this issue Feb 13, 2018
@behlendorf @Nasf-Fan
Emit history events for 'zpool create'
c5d17bc 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712
Closes openzfs#6486
FransUrbo pushed a commit to FransUrbo/zfs that referenced this issue Apr 28, 2019
@behlendorf @FransUrbo
Emit history events for 'zpool create'
b743d59 
History commands and events were being suppressed for the
'zpool create' command since the history object did not
yet exist.  Create the object earlier so this history
doesn't get lost.

Split the pool_destroy event in to pool_destroy and
pool_export so they may be distinguished.

Updated events_001_pos and events_002_pos test cases.  They
now check for the expected history events and were reworked
to be more reliable.

Reviewed-by: Nathaniel Clark <nathaniel.l.clark@intel.com>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#6712 
Closes openzfs#6486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dinatale2