"zpool status -c temp" not working across various disks

[bunder2015]

System information

Type	Version/Name
Distribution Name	gentoo
Distribution Version	n/a
Linux Kernel	n/a
Architecture	n/a
ZFS Version	various 0.7.x git
SPL Version	various 0.7.x git

Describe the problem you're observing

zpool status -c temp doesn't appear to work on Samsung SSDs or NVMEs, possibly other makes/models of disks. This is actually fairly common with hddtempd, they maintain a database of attributes to look for when probing temperatures. In the case of the SSDs below, they use 190 Airflow_Temperature_Cel instead of 194 Temperature_Celsius. The NVME doesn't list attribute numbers, and actually reports 3 sensors, "Temperature", "Temperature Sensor 1" and 2.

Describe how to reproduce the problem

Run zpool status -c temp on a pool with various disks installed

Include any warning/errors/backtraces from the system logs

bloomfield ~ # ZPOOL_SCRIPTS_PATH=/etc/zfs/zpool.d/ ZPOOL_SCRIPTS_AS_ROOT=1 zpool status -c temp
  pool: b-pool
 state: ONLINE
status: Some supported features are not enabled on the pool. The pool can
        still be used, but some features are unavailable.
action: Enable all features using 'zpool upgrade'. Once this is done,
        the pool may no longer be accessible by software that does not support
        the features. See zpool-features(5) for details.
  scan: scrub repaired 0B in 0 days 00:30:03 with 0 errors on Fri Feb 16 04:00:04 2018
config:

        NAME                                                     STATE     READ WRITE CKSUM  temp
        b-pool                                                   ONLINE       0     0     0
          raidz2-0                                               ONLINE       0     0     0
            ata-WDC_WD1003FBYZ-010FB0-part1WD-WCAW37498843       ONLINE       0     0     0    28
            ata-WDC_WD1003FBYZ-010FB0-part1WD-WCAW3KUDTD5S       ONLINE       0     0     0    29
            ata-WDC_WD1003FBYZ-010FB0-part1WD-WCAW3REX5UK3       ONLINE       0     0     0    30
            ata-WDC_WD1003FBYZ-010FB0-part1WD-WCAW37357425       ONLINE       0     0     0    30
            ata-WDC_WD1003FBYZ-010FB0-part1WD-WCAW37439816       ONLINE       0     0     0    33
        logs
          mirror-1                                               ONLINE       0     0     0
            ata-Samsung_SSD_850_EVO_120GB_S21TNXAGB04076F-part2  ONLINE       0     0     0     -
            ata-Samsung_SSD_850_EVO_120GB_S21TNXAGB06637N-part2  ONLINE       0     0     0     -
        cache
          ata-Samsung_SSD_850_EVO_120GB_S21TNXAGB04076F-part1    ONLINE       0     0     0     -
          ata-Samsung_SSD_850_EVO_120GB_S21TNXAGB06637N-part1    ONLINE       0     0     0     -

errors: No known data errors

firewall ~ # ZPOOL_SCRIPTS_PATH=/etc/zfs/zpool.d/ ZPOOL_SCRIPTS_AS_ROOT=1 zpool status -c temp
  pool: fw-pool
 state: ONLINE
status: Some supported features are not enabled on the pool. The pool can
        still be used, but some features are unavailable.
action: Enable all features using 'zpool upgrade'. Once this is done,
        the pool may no longer be accessible by software that does not support
        the features. See zpool-features(5) for details.
  scan: scrub repaired 0B in 0 days 00:00:13 with 0 errors on Fri Feb 16 03:30:14 2018
config:

        NAME                                                     STATE     READ WRITE CKSUM  temp
        fw-pool                                                  ONLINE       0     0     0
          mirror-0                                               ONLINE       0     0     0
            ata-Samsung_SSD_850_EVO_250GB_S2R5NX0J505885R-part2  ONLINE       0     0     0     -
            ata-Samsung_SSD_850_EVO_250GB_S2R5NX0J505886X-part2  ONLINE       0     0     0     -

errors: No known data errors

gazelle ~ # ZPOOL_SCRIPTS_PATH=/etc/zfs/zpool.d/ ZPOOL_SCRIPTS_AS_ROOT=1 zpool status -c temp
  pool: g-pool
 state: ONLINE
status: Some supported features are not enabled on the pool. The pool can
        still be used, but some features are unavailable.
action: Enable all features using 'zpool upgrade'. Once this is done,
        the pool may no longer be accessible by software that does not support
        the features. See zpool-features(5) for details.
  scan: scrub repaired 0B in 0 days 00:00:24 with 0 errors on Fri Feb 16 03:30:25 2018
config:

        NAME         STATE     READ WRITE CKSUM  temp
        g-pool       ONLINE       0     0     0
          nvme0n1p2  ONLINE       0     0     0     -

errors: No known data errors

[loli10K]

@bunder2015 thank you for reporting this.

Are you already working on a fix? If so, would you mind if this issue gets assigned to you?

[bunder2015]

I think I have something working for SSD, but I'm trying to see if I can get NVME working as well.

edit: I should note that appears that sudo is required for these scripts to work, although you won't see any errors indicating that.

[loli10K]

Nice, thanks. I've seen you edit your report multiple times, it looked to me you were onto something.

[tonyhutter]

I should note that appears that sudo is required for these scripts to work,
although you won't see any errors indicating that.

Yea, unfortunately the -c error reporting is non-existent at this time. We do provide a sudoers rule that people can use to allow smartctl for unprivilaged users (etc/sudoers.d/zfs mentioned in zpool(8))