Change the error handling for invalid property values during receive #10631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanjude
force-pushed
the
openzfs_zstd_compat
branch
from
5194888
to
aab3ae1
Compare
12 tasks
allanjude
force-pushed
the
openzfs_zstd_compat
branch
from
aab3ae1
to
b21aa5c
Compare
behlendorf
reviewed
Jul 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #10631 +/- ##
==========================================
+ Coverage 79.55% 79.97% +0.42%
==========================================
Files 394 394
Lines 124631 124637 +6
==========================================
+ Hits 99146 99679 +533
+ Misses 25485 24958 -527
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
allanjude
force-pushed
the
openzfs_zstd_compat
branch
2 times, most recently
from
95ad0e5
to
2d76775
Compare
|
Updated pyzfs tests to handle the new error code. They will still fail until #10649 is merged |
behlendorf
approved these changes
Jul 30, 2020
|
#10649 has been merged. Would you mind rebasing this on the latest so we can get a fresh test run. |
ZFS recv should return a useful error message when an invalid index property value is provided in the send stream properties nvlist With a compression= property outside of the understood range: Before: ``` receiving full stream of zof/zstd_send@send2 into testpool/recv@send2 internal error: Invalid argument Aborted (core dumped) ``` Note: the recv completes successfully, the abort() is likely just to make it easier to track the unexpected error code. After: ``` receiving full stream of zof/zstd_send@send2 into testpool/recv@send2 cannot receive compression property on testpool/recv: invalid property value received 28.9M stream in 1 seconds (28.9M/sec) ``` Signed-off-by: Allan Jude <allan@klarasystems.com>
allanjude
force-pushed
the
openzfs_zstd_compat
branch
from
2d76775
to
e0bd009
Compare
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
ZFS recv should return a useful error message when an invalid index property value is provided in the send stream properties nvlist With a compression= property outside of the understood range: Before: ``` receiving full stream of zof/zstd_send@send2 into testpool/recv@send2 internal error: Invalid argument Aborted (core dumped) ``` Note: the recv completes successfully, the abort() is likely just to make it easier to track the unexpected error code. After: ``` receiving full stream of zof/zstd_send@send2 into testpool/recv@send2 cannot receive compression property on testpool/recv: invalid property value received 28.9M stream in 1 seconds (28.9M/sec) ``` Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Allan Jude <allan@klarasystems.com> Closes openzfs#10631
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
ZFS recv should return a useful error message when an invalid index property value is provided in the send stream properties nvlist With a compression= property outside of the understood range: Before: ``` receiving full stream of zof/zstd_send@send2 into testpool/recv@send2 internal error: Invalid argument Aborted (core dumped) ``` Note: the recv completes successfully, the abort() is likely just to make it easier to track the unexpected error code. After: ``` receiving full stream of zof/zstd_send@send2 into testpool/recv@send2 cannot receive compression property on testpool/recv: invalid property value received 28.9M stream in 1 seconds (28.9M/sec) ``` Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Allan Jude <allan@klarasystems.com> Closes openzfs#10631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allan Jude allan@klarasystems.com
Motivation and Context
zfs recvshould return a useful error message when an invalid indexproperty value is provided in the send stream properties nvlist
Description
With a compression= property outside of the understood range:
Before:
Note: the recv completes successfully, the abort() is likely just to
make it easier to track the unexpected error code.
After:
How Has This Been Tested?
zfs send from a system with ZSTD support, to a system without ZSTD support
Types of changes
Checklist:
Signed-off-by.