Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: FreeBSD does have a l2arc.trim_ahead tunable #10633

Merged
merged 1 commit into from Aug 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 28, 2020

Signed-off-by: Ryan Moeller ryan@iXsystems.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added Component: Test Suite Indicates an issue with the test framework or a test case Status: Code Review Needed Ready for review and testing labels Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #10633 into master will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10633      +/-   ##
==========================================
- Coverage   79.55%   79.25%   -0.31%     
==========================================
  Files         394      394              
  Lines      124641   124641              
==========================================
- Hits        99164    98782     -382     
- Misses      25477    25859     +382     
Flag Coverage Δ
#kernel 80.14% <ø> (-0.29%) ⬇️
#user 63.73% <ø> (-1.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/os/linux/spl/spl-zlib.c 55.35% <0.00%> (-28.58%) ⬇️
module/zcommon/zfs_fletcher.c 68.09% <0.00%> (-10.20%) ⬇️
module/os/linux/spl/spl-kmem-cache.c 78.52% <0.00%> (-8.95%) ⬇️
cmd/ztest/ztest.c 69.21% <0.00%> (-6.55%) ⬇️
cmd/zvol_id/zvol_id_main.c 76.31% <0.00%> (-5.27%) ⬇️
module/zfs/bptree.c 88.54% <0.00%> (-5.21%) ⬇️
module/os/linux/zfs/arc_os.c 59.50% <0.00%> (-4.96%) ⬇️
module/zcommon/zfs_fletcher_superscalar.c 97.05% <0.00%> (-2.95%) ⬇️
module/zfs/zio_compress.c 89.74% <0.00%> (-2.57%) ⬇️
module/zfs/vdev_indirect.c 72.50% <0.00%> (-2.17%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eabed7...b65b7f0. Read the comment docs.

@ghost ghost requested a review from behlendorf July 31, 2020 16:20
@behlendorf behlendorf merged commit af524bf into openzfs:master Aug 1, 2020
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 1, 2020
@ghost ghost deleted the trim-ahead-tunable branch August 1, 2020 15:14
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10633
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#10633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant