Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Remove unused SECLABEL code #10847

Merged
merged 1 commit into from Sep 1, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 29, 2020

Motivation and Context

SECLABEL is undefined on FreeBSD.

Description

Prune ifdef SECLABEL code.

How Has This Been Tested?

Compiled

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
@ghost ghost added the Status: Code Review Needed Ready for review and testing label Aug 29, 2020
@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #10847 into master will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10847      +/-   ##
==========================================
- Coverage   79.88%   79.51%   -0.37%     
==========================================
  Files         395      395              
  Lines      125066   125066              
==========================================
- Hits        99905    99445     -460     
- Misses      25161    25621     +460     
Flag Coverage Δ
#kernel 80.31% <ø> (-0.08%) ⬇️
#user 64.47% <ø> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/zdb/zdb_il.c 30.86% <0.00%> (-24.08%) ⬇️
module/os/linux/spl/spl-kmem-cache.c 78.44% <0.00%> (-11.64%) ⬇️
cmd/ztest/ztest.c 76.20% <0.00%> (-5.91%) ⬇️
cmd/zvol_id/zvol_id_main.c 76.31% <0.00%> (-5.27%) ⬇️
module/zfs/vdev_indirect.c 73.37% <0.00%> (-3.83%) ⬇️
module/zfs/vdev_removal.c 94.05% <0.00%> (-2.63%) ⬇️
module/zfs/vdev_indirect_mapping.c 97.10% <0.00%> (-1.94%) ⬇️
module/zfs/zio_compress.c 92.72% <0.00%> (-1.82%) ⬇️
module/zfs/metaslab.c 93.93% <0.00%> (-1.81%) ⬇️
module/zfs/vdev_queue.c 94.69% <0.00%> (-1.77%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62663fb...1f5f63d. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 1, 2020
@behlendorf behlendorf merged commit 88d19d7 into openzfs:master Sep 1, 2020
@ghost ghost deleted the no-seclabel branch September 1, 2020 13:04
behlendorf pushed a commit that referenced this pull request Sep 3, 2020
SECLABEL is undefined on FreeBSD and should be pruned.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes #10847
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
SECLABEL is undefined on FreeBSD and should be pruned.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes openzfs#10847
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
SECLABEL is undefined on FreeBSD and should be pruned.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes openzfs#10847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant