Illumos #3145, #3212 #1160
Closed
Illumos #3145, #3212 #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illumos-gate/commit/9253d63df408bb48584e0b1abfcc24ef2472382e Illumos changeset: 13840:97fd5cdf328a 3145 single-copy arc 3212 ztest: race condition between vdev_online() and spa_vdev_remove() Reviewed by: Matt Ahrens <matthew.ahrens@delphix.com> Reviewed by: Adam Leventhal <ahl@delphix.com> Reviewed by: Eric Schrock <eric.schrock@delphix.com> Reviewed by: Justin T. Gibbs <gibbs@scsiguy.com> Approved by: Eric Schrock <eric.schrock@delphix.com> Ported-by: Brian Behlendorf <behlendorf1@llnl.gov> Issue openzfs#989 Issue openzfs#1137
pcd1193182
pushed a commit
to pcd1193182/zfs
that referenced
this pull request
Sep 26, 2023
When restarting the agent, it uses ListObjects operations to find any objects
that are part of the in-progress TXG. If there are a large number of these
objects, this may take a while, resulting in the following agent panic:
```
thread 'zoa' panicked at 'called `Result::unwrap()` on an `Err` value: request has timed out
Caused by:
operation attempt timeout (single attempt) occurred after 2s', zettaobject/src/object_access/mod.rs:491:42
stack backtrace:
...
zettaobject::object_access::ObjectAccess::try_list_after::{{closure}}
at zfs/cmd/zfs_object_agent/zettaobject/src/object_access/mod.rs:491:35
...
8: zettaobject::pool::recover_list::{{closure}}::{{closure}}::{{closure}}
at zfs/cmd/zfs_object_agent/zettaobject/src/pool.rs:1928:17
```
The problem is that we configure the “retrying” client of the AWS SDK to have a
2 second timeout. (This “retrying” client is only used for ListObjects
requests.) After this timeout expires, the SDK returns an error. However, in
this case the request may reasonably take longer, and we want to keep waiting.
The fix is to not configure a timeout on the “retrying” client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
illumos-gate/commit/9253d63df408bb48584e0b1abfcc24ef2472382e
Illumos changeset: 13840:97fd5cdf328a
3145 single-copy arc
3212 ztest: race condition between vdev_online() and spa_vdev_remove()
Reviewed by: Matt Ahrens matthew.ahrens@delphix.com
Reviewed by: Adam Leventhal ahl@delphix.com
Reviewed by: Eric Schrock eric.schrock@delphix.com
Reviewed by: Justin T. Gibbs gibbs@scsiguy.com
Approved by: Eric Schrock eric.schrock@delphix.com
Ported-by: Brian Behlendorf behlendorf1@llnl.gov
Issue #989
Issue #1137