Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: damage control racing .. lookups in face of mkdir/rmdir #11926

Merged
merged 1 commit into from
Apr 26, 2021
Merged

FreeBSD: damage control racing .. lookups in face of mkdir/rmdir #11926

merged 1 commit into from
Apr 26, 2021

Conversation

mjguzik
Copy link
Contributor

@mjguzik mjguzik commented Apr 22, 2021

Signed-off-by: Mateusz Guzik mjguzik@gmail.com

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost ghost added this to In progress in FreeBSD via automation Apr 22, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
663463a 
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
@behlendorf behlendorf requested a review from amotin April 22, 2021 15:56
amotin
amotin approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really familiar with this code, but I trust kib@'s review: https://reviews.freebsd.org/D29769

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Apr 22, 2021
@behlendorf
Copy link
Contributor

Thanks for linking to the review. Then I'll get this merged.

@behlendorf behlendorf merged commit f172f75 into openzfs:master Apr 26, 2021
FreeBSD automation moved this from In progress to Done Apr 26, 2021
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
217641c 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
58d3771 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 6, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
e3b8602 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 7, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
79fc2c7 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
6c58c6c 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
c49769f 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 10, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
1e11816 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 10, 2021
@mjguzik @behlendorf
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
1b7d883 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 13, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
fc08615 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
ghost pushed a commit to truenas/zfs that referenced this pull request May 17, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
79c5a67 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
behlendorf pushed a commit that referenced this pull request May 20, 2021
@mjguzik @behlendorf
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
343e90a 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #11926
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@mjguzik
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
6613cc3 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes openzfs#11926
tonyhutter pushed a commit that referenced this pull request Jun 23, 2021
@mjguzik @tonyhutter
FreeBSD: damage control racing .. lookups in face of mkdir/rmdir
a78a93e 
External-issue: https://reviews.freebsd.org/D29769
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Closes #11926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
FreeBSD
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjguzik @behlendorf @amotin