Fix AVX512BW Fletcher code on AVX512-but-not-BW machines. #11938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes openzfs#11937 Signed-off-by: Romain Dolbeau <romain@dolbeau.org>
adamdmoss
approved these changes
Apr 25, 2021
behlendorf
approved these changes
Apr 26, 2021
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 6, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 6, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 6, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 7, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 10, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 10, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 10, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
May 10, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 13, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
ghost
pushed a commit
to truenas/zfs
that referenced
this pull request
May 17, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f). Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Adam Moss <c@yotes.com> Signed-off-by: Romain Dolbeau <romain@dolbeau.org> Closes openzfs#11937 Closes openzfs#11938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11937
Signed-off-by: Romain Dolbeau romain@dolbeau.org
Motivation and Context
See #11937; the wrong simd code is run on x86-64 machine with AVX512F but not AVX512BW (i.e., only Knight Landings a.k.a. Xeon Phi).
Description
Introduce a specific valid function for avx512f+avx512bw (instead of checking only for avx512f).
How Has This Been Tested?
Original bug reported confirms it solves the issue.
Types of changes
Checklist:
Signed-off-by.