Add explicit error for device_rebuild being disabled #12680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
(I ran into #11414, that's really all.)
Currently, you get back "can only attach to mirrors and top-level disks"
unconditionally if zpool attach returns ENOTSUP, but that also happens
if, say, feature@device_rebuild=disabled and you tried attach -s.
Description
Adds an error case for ENOTSUP and feature@device_rebuild=disabled.
(I don't check for unsupported explicitly because it's checked earlier in the function; I considered adding this error check right below that one, but opted to put it with the ENOTSUP return handling rather than another special case early on. If people disagree strongly, I can move it.)
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.