argSUSed: cmd, tests, contrib #12835

nabijaczleweli · 2021-12-11T01:15:50Z

Motivation and Context

~~A comment is a comment.~~ there are 2 unused arguments among us.

Description

~~Draft because on top of #12829, otherwise~~ g2g

Also, in zdb, is

static void dump_uint8(objset_t *os, uint64_t object, void *data, size_t size)

supposed to be empty?

How Has This Been Tested?

make -C cmd/, -C tests/, and -C contrib builds clean on clang 14 when configured with -Wall -Wextra -Wno-sign-compare -Wno-missing-field-initializers in CFLAGS

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance enhancement (non-breaking change which improves efficiency)
Code cleanup (non-breaking change which makes code smaller or more readable)
Breaking change (fix or feature that would cause existing functionality to change)
Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
Documentation (a change to man pages or other documentation)

Checklist:

My code follows the OpenZFS code style requirements.
I have updated the documentation accordingly.
I have read the contributing document.
I have added tests to cover my changes. – none apply
I have run the ZFS Test Suite with this change applied. – likewise
All commit messages are properly formatted and contain Signed-off-by.

nabijaczleweli · 2021-12-14T13:18:59Z

Rebased, should be g2g

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

Bullseye shellcheck picks these up as SC2140, and it's right! @LIBFETCH_SONAME@ is already quoted, so dracut had "$d/"libcurl.so.4"" and i-t had ""libcurl.so.4"" Partially reverts 34eef3e (openzfs#12760), which broke this Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

Bullseye shellcheck picks these up as SC2140, and it's right! @LIBFETCH_SONAME@ is already quoted, so dracut had "$d/"libcurl.so.4"" and i-t had ""libcurl.so.4"" Partially reverts 34eef3e (openzfs#12760), which broke this Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

@LIBFETCH_SONAME@ is no longer quoted. The C define still is. Ref: 153f7c9 Ref: openzfs#12835 (comment) Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12922

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

Bullseye shellcheck picks these up as SC2140, and it's right! @LIBFETCH_SONAME@ is already quoted, so dracut had "$d/"libcurl.so.4"" and i-t had ""libcurl.so.4"" Partially reverts 34eef3e (openzfs#12760), which broke this Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

@LIBFETCH_SONAME@ is no longer quoted. The C define still is. Ref: 153f7c9 Ref: openzfs#12835 (comment) Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12922

nabijaczleweli changed the title ~~argSUSed: cmd~~ argSUSed: cmd, tests Dec 11, 2021

nabijaczleweli changed the title ~~argSUSed: cmd, tests~~ argSUSed: cmd, tests, contrib Dec 11, 2021

nabijaczleweli force-pushed the cmd-ARGSUSED branch 2 times, most recently from 7945730 to d97bfed Compare December 12, 2021 14:07

nabijaczleweli mentioned this pull request Dec 12, 2021

argSUSed: lib (so also the bit of module that is built for lib), include #12844

Closed

13 tasks

nabijaczleweli force-pushed the cmd-ARGSUSED branch from d97bfed to aac3de0 Compare December 14, 2021 13:17

nabijaczleweli marked this pull request as ready for review December 14, 2021 13:18

behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 16, 2021

nabijaczleweli force-pushed the cmd-ARGSUSED branch from aac3de0 to 718aa16 Compare December 17, 2021 21:36

nabijaczleweli added 20 commits December 21, 2021 16:18

raidz_test: init_rand: fix unused, remove argsused

dd3e572

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zhack: space_delta_cb: fix unused, remove argsused

910409b

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zinject: cancel_one_handler: fix unused, remove argsused

a1ce39a

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zpool: iter: zpool_compare: fix unused, remove argsused

7a668c1

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zpool: main: fix unused, remove argsused

4b2a6de

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zpool: vdev_os: fix unused, remove argsused

340945b

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: main: fix unused, remove argsused

a94da8c

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: exec: fix unused, remove argsused

871b078

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: agents: fix unused, remove argsused

28c98a4

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: agents: zfs_diagnosis: fix unused, remove argsused

95672dc

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: agents: zfs_mod: fix unused, remove argsused

313d8e1

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: agents: zfs_retire: fix unused, remove argsused

f0a74ba

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zed: agents: fmd_api: fix unused, remove argsused

b5356c1

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zdb: main: fix unused, remove argsused

2c10382

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zdb: il: fix unused, remove argsused

4c12641

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

ztest: fix unused, remove argsused

3350a9f

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

zfs: iter: fix unused, remove argsused

388ebe6

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

tests: fix unused, remove argsused

235c094

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

contrib/pam_zfs_key: fix unused, remove argsused

f25ce0e

Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zdb: main: fix unused, remove argsused

88cc5b2

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zdb: il: fix unused, remove argsused

2e73d03

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

ztest: fix unused, remove argsused

1f29e61

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zfs: iter: fix unused, remove argsused

86091d1

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

tests: fix unused, remove argsused

f109595

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

contrib/pam_zfs_key: fix unused, remove argsused

d434b95

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

raidz_test: init_rand: fix unused, remove argsused

7e89253

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zhack: space_delta_cb: fix unused, remove argsused

13e806f

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zpool: main: fix unused, remove argsused

c55a32b

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zpool: vdev_os: fix unused, remove argsused

d4293ac

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zed: main: fix unused, remove argsused

88a3b99

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zed: exec: fix unused, remove argsused

cd4646e

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zed: agents: fix unused, remove argsused

6428d4b

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zed: agents: zfs_mod: fix unused, remove argsused

ef9ec7d

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zed: agents: fmd_api: fix unused, remove argsused

bc51229

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zdb: main: fix unused, remove argsused

2b65ad0

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zdb: il: fix unused, remove argsused

2c9e72c

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

ztest: fix unused, remove argsused

84c0435

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

zfs: iter: fix unused, remove argsused

67f38c4

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

tests: fix unused, remove argsused

099af7c

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022

contrib/pam_zfs_key: fix unused, remove argsused

cfa3bd8

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Closes openzfs#12835

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

argSUSed: cmd, tests, contrib #12835

argSUSed: cmd, tests, contrib #12835

nabijaczleweli commented Dec 11, 2021 •

edited

nabijaczleweli commented Dec 14, 2021

argSUSed: cmd, tests, contrib #12835

argSUSed: cmd, tests, contrib #12835

Conversation

nabijaczleweli commented Dec 11, 2021 • edited

Motivation and Context

Description

How Has This Been Tested?

Types of changes

Checklist:

nabijaczleweli commented Dec 14, 2021

nabijaczleweli commented Dec 11, 2021 •

edited