Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep debug symbols if configured with '--enable-debuginfo' #13500

Merged
merged 1 commit into from May 25, 2022
Merged

Keep debug symbols if configured with '--enable-debuginfo' #13500

merged 1 commit into from May 25, 2022

Conversation

usaleem-ix
Copy link
Contributor

Motivation and Context

Keep debug symbols in packages if configured with '--enable-debuginfo'.

Description

Do not strip debug information from packages if '--enable-debuginfo' is
configured.

How Has This Been Tested?

Tested via CI.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@usaleem-ix
Packaging: Keep debug symbols if configured with '--enable-debuginfo'
d0bfbc4 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
@behlendorf behlendorf added the Component: Packaging custom packages label May 24, 2022
@usaleem-ix
Copy link
Contributor Author

CI failures seem unrelated here.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 25, 2022
@behlendorf behlendorf merged commit b37093a into openzfs:master May 25, 2022
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 25, 2022
@usaleem-ix @behlendorf
rpm: Keep debug symbols if configured with '--enable-debuginfo'
3627d63 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
@usaleem-ix usaleem-ix deleted the NAS-111673 branch May 26, 2022 06:51
behlendorf pushed a commit that referenced this pull request May 27, 2022
@usaleem-ix @behlendorf
rpm: Keep debug symbols if configured with '--enable-debuginfo'
0a688b2 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes #13500
usaleem-ix added a commit to truenas/zfs that referenced this pull request Jun 2, 2022
@usaleem-ix
rpm: Keep debug symbols if configured with '--enable-debuginfo'
9f110a4 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@usaleem-ix @nicman23
rpm: Keep debug symbols if configured with '--enable-debuginfo'
a7405ee 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@usaleem-ix @nicman23
rpm: Keep debug symbols if configured with '--enable-debuginfo'
41bbd4e 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 12, 2022
@usaleem-ix @lundman
rpm: Keep debug symbols if configured with '--enable-debuginfo'
74515e0 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@usaleem-ix @beren12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
66de256 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
61e3e99 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
edfbee1 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
4afb6b2 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
1a2e465 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
a09a01d 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
4c20057 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
4527e7b 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
1dd0aa6 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
47407a4 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
2f5939a 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
cf37c57 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
2388198 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
85c6d31 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
b68bcb3 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
9f25321 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
88ef150 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
3671f1a 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
750453b 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
34f49e4 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
6ab20e5 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
860ce52 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
e13616a 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
e81fa70 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
ea7cde4 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
0ef466d 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@usaleem-ix @andrewc12
rpm: Keep debug symbols if configured with '--enable-debuginfo'
d8f9d1c 
Do not strip debug information from packages if '--enable-debuginfo' is
configured.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Umer Saleem <usaleem@ixsystems.com>
Closes openzfs#13500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Component: Packaging custom packages Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@usaleem-ix @behlendorf