Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zfs_btree_verify_intensity kernel module parameter #13874

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Add zfs_btree_verify_intensity kernel module parameter #13874

merged 1 commit into from
Sep 15, 2022

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Sep 12, 2022

Motivation and Context

I see a few issues in the issue tracker that might be aided by being able to turn this on. We have no module parameter for it, so I would like to add one.

Description

How Has This Been Tested?

A build test was done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 12, 2022
behlendorf
behlendorf reviewed Sep 12, 2022
View reviewed changes
module/zfs/btree.c Show resolved Hide resolved
man/man4/zfs.4 Show resolved Hide resolved
@ryao ryao marked this pull request as draft September 12, 2022 23:23
@ryao ryao marked this pull request as ready for review September 13, 2022 13:32
amotin
amotin reviewed Sep 13, 2022
View reviewed changes
module/zfs/btree.c Outdated Show resolved Hide resolved
@ryao ryao mentioned this pull request Sep 13, 2022
Merged
13 tasks
@ryao
Add zfs_btree_verify_intensity kernel module parameter
00be634 
I see a few issues in the issue tracker that might be aided by being
able to turn this on. We have no module parameter for it, so I would
like to add one.

Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 15, 2022
@behlendorf behlendorf merged commit b24d1c7 into openzfs:master Sep 15, 2022
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 22, 2022
@ryao @tonyhutter
Add zfs_btree_verify_intensity kernel module parameter
b66f8d3 
I see a few issues in the issue tracker that might be aided by being
able to turn this on. We have no module parameter for it, so I would
like to add one.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13874
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 27, 2022
@ryao @andrewc12
Add zfs_btree_verify_intensity kernel module parameter
6207899 
I see a few issues in the issue tracker that might be aided by being
able to turn this on. We have no module parameter for it, so I would
like to add one.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13874
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@ryao @andrewc12
Add zfs_btree_verify_intensity kernel module parameter
513fcc4 
I see a few issues in the issue tracker that might be aided by being
able to turn this on. We have no module parameter for it, so I would
like to add one.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13874
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@ryao @andrewc12
Add zfs_btree_verify_intensity kernel module parameter
f8ebde5 
I see a few issues in the issue tracker that might be aided by being
able to turn this on. We have no module parameter for it, so I would
like to add one.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13874
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 1, 2022
@ryao @andrewc12
Add zfs_btree_verify_intensity kernel module parameter
6ed081a 
I see a few issues in the issue tracker that might be aided by being
able to turn this on. We have no module parameter for it, so I would
like to add one.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes openzfs#13874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

@pcd1193182 pcd1193182 Awaiting requested review from pcd1193182

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryao @behlendorf @amotin