New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retire Ubuntu 18.04 CI builder #14238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub-hosted Ubuntu 18.04 has been deprecated and will be entirely unsupported as of April 2023. Leading up to this there will be scheduled "brownouts" to encourage users to update their workflows. This commit retires our use of the GitHub-hosted Ubuntu 18.04 runners in advance of their removal. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
ryao
approved these changes
Nov 29, 2022
gmelikov
approved these changes
Nov 30, 2022
szubersk
approved these changes
Nov 30, 2022
The reason CI hits the timeout is (logs from this PR)
The bug above manifests itself more often on Ubuntu 18.04 (I downloaded 18.04 logs a couple of times from different PRs) than others but still. |
szubersk
added a commit
to szubersk/zfs
that referenced
this pull request
Nov 30, 2022
- `ubuntu-latest` now resolves to `ubuntu-22.04`. Explicit pinning is needed. - cherry-pick openzfs#14238 Signed-off-by: szubersk <szuberskidamian@gmail.com>
13 tasks
Ah, I hadn't seen that. Was there anything else interesting in the log before that stack? We should get an issue open to at least track this. |
behlendorf
added
Status: Accepted
Ready to integrate (reviewed, tested)
and removed
Status: Code Review Needed
Ready for review and testing
labels
Nov 30, 2022
szubersk
added a commit
to szubersk/zfs
that referenced
this pull request
Dec 7, 2022
- `ubuntu-latest` now resolves to `ubuntu-22.04`. Explicit pinning is needed. - cherry-pick openzfs#14238 Signed-off-by: szubersk <szuberskidamian@gmail.com>
behlendorf
pushed a commit
that referenced
this pull request
Dec 9, 2022
- `ubuntu-latest` now resolves to `ubuntu-22.04`. Explicit pinning is needed. - cherry-pick #14238 Signed-off-by: szubersk <szuberskidamian@gmail.com>
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Dec 16, 2022
The GitHub-hosted Ubuntu 18.04 has been deprecated and will be entirely unsupported as of April 2023. Leading up to this there will be scheduled "brownouts" to encourage users to update their workflows. This commit retires our use of the GitHub-hosted Ubuntu 18.04 runners in advance of their removal. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#14238
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Dec 17, 2022
The GitHub-hosted Ubuntu 18.04 has been deprecated and will be entirely unsupported as of April 2023. Leading up to this there will be scheduled "brownouts" to encourage users to update their workflows. This commit retires our use of the GitHub-hosted Ubuntu 18.04 runners in advance of their removal. Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#14238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The GitHub-hosted Ubuntu 18.04 has been deprecated and will be entirely unsupported as of April 2023. Leading up to this there will be scheduled "brownouts" to encourage users to update their workflows.
Retiring these runners now also has the advantage of resolving the frequent CI failures on Ubuntu 18.04 due to hitting the maximum instance run time. This is believed to be caused by these running using older, slower, hardware.
Description
This commit retires our use of the GitHub-hosted Ubuntu 18.04 runners in advance of their removal.
How Has This Been Tested?
Locally inspected, will be tested by the CI.
Checklist:
Signed-off-by
.