Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire Ubuntu 18.04 CI builder #14238

Merged
merged 1 commit into from Nov 30, 2022

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

The GitHub-hosted Ubuntu 18.04 has been deprecated and will be entirely unsupported as of April 2023. Leading up to this there will be scheduled "brownouts" to encourage users to update their workflows.

Retiring these runners now also has the advantage of resolving the frequent CI failures on Ubuntu 18.04 due to hitting the maximum instance run time. This is believed to be caused by these running using older, slower, hardware.

Description

This commit retires our use of the GitHub-hosted Ubuntu 18.04 runners in advance of their removal.

How Has This Been Tested?

Locally inspected, will be tested by the CI.

Checklist:

The GitHub-hosted Ubuntu 18.04 has been deprecated and will be
entirely unsupported as of April 2023.  Leading up to this there
will be scheduled "brownouts" to encourage users to update their
workflows.

This commit retires our use of the GitHub-hosted Ubuntu 18.04
runners in advance of their removal.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 29, 2022
@szubersk
Copy link
Contributor

The reason CI hits the timeout is (logs from this PR)

[ 9719.718092] ZTS run /usr/share/zfs/zfs-tests/tests/functional/mmp/mmp_active_import                                             
[10030.729687] INFO: task zpool:1268006 blocked for more than 120 seconds.                                                         
[10030.736226]       Tainted: P           OE     5.15.0-1023-azure #29~20.04.1-Ubuntu                                              
[10030.743056] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.                                           
[10030.750482] task:zpool           state:D stack:    0 pid:1268006 ppid:1259863 flags:0x00004000                                  
[10030.750488] Call Trace:                                                                                                         
[10030.750491]  <TASK>                                                                                                             
[10030.750495]  __schedule+0x2c2/0x8e0                                                                                             
[10030.750501]  schedule+0x69/0x110                                                                                                
[10030.750506]  cv_wait_common+0x157/0x260 [spl]                                                                                   
[10030.750518]  ? wait_woken+0x60/0x60                                                                                             
[10030.750524]  __cv_wait+0x15/0x20 [spl]                                                                                          
[10030.750531]  vdev_autotrim_stop_wait+0x67/0xe0 [zfs]                                                                            
[10030.750726]  vdev_autotrim_stop_all+0x35/0x50 [zfs]                                                                             
[10030.750889]  spa_export_common+0x327/0x5a0 [zfs]                                                                                

The bug above manifests itself more often on Ubuntu 18.04 (I downloaded 18.04 logs a couple of times from different PRs) than others but still.

szubersk added a commit to szubersk/zfs that referenced this pull request Nov 30, 2022
- `ubuntu-latest` now resolves to `ubuntu-22.04`. Explicit pinning
  is needed.

- cherry-pick openzfs#14238

Signed-off-by: szubersk <szuberskidamian@gmail.com>
@behlendorf
Copy link
Contributor Author

Ah, I hadn't seen that. Was there anything else interesting in the log before that stack? We should get an issue open to at least track this.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 30, 2022
@behlendorf behlendorf merged commit 3a6d89a into openzfs:master Nov 30, 2022
szubersk added a commit to szubersk/zfs that referenced this pull request Dec 7, 2022
- `ubuntu-latest` now resolves to `ubuntu-22.04`. Explicit pinning
  is needed.

- cherry-pick openzfs#14238

Signed-off-by: szubersk <szuberskidamian@gmail.com>
behlendorf pushed a commit that referenced this pull request Dec 9, 2022
- `ubuntu-latest` now resolves to `ubuntu-22.04`. Explicit pinning
  is needed.

- cherry-pick #14238

Signed-off-by: szubersk <szuberskidamian@gmail.com>
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 16, 2022
The GitHub-hosted Ubuntu 18.04 has been deprecated and will be
entirely unsupported as of April 2023.  Leading up to this there
will be scheduled "brownouts" to encourage users to update their
workflows.

This commit retires our use of the GitHub-hosted Ubuntu 18.04
runners in advance of their removal.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#14238
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Dec 17, 2022
The GitHub-hosted Ubuntu 18.04 has been deprecated and will be
entirely unsupported as of April 2023.  Leading up to this there
will be scheduled "brownouts" to encourage users to update their
workflows.

This commit retires our use of the GitHub-hosted Ubuntu 18.04
runners in advance of their removal.

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#14238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants