Values printed by zpool-iostat(8) should be right-aligned #14751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inappropriate left-alignment was introduced in 7bb7b1f. Signed-off-by: WHR <msl0000023508@gmail.com>
mcmilk
approved these changes
Apr 15, 2023
| { | ||
| fputs(" ", stdout); | ||
| size_t len = strlen(statbuf); | ||
| while (len < column_size) { |
There was a problem hiding this comment.
I would add a new line before the while() .... but this is cosmetic ;)
| if (*statbuf == '0') { | ||
| color_start(ANSI_GRAY); | ||
| fputc('0', stdout); | ||
| column_size--; |
There was a problem hiding this comment.
How about adding color_end(); and return; here ....
And we can put the whole for() loop a tab to the left.
There was a problem hiding this comment.
Good point. May be we can do these code cleanups later.
Now I also feels that the series of else if inside for should probably be turned into a switch instead for readability.
ahrens
approved these changes
Apr 16, 2023
|
@Low-power thanks! |
tonyhutter
reviewed
Apr 17, 2023
tonyhutter
approved these changes
Apr 18, 2023
behlendorf
approved these changes
Apr 18, 2023
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Apr 18, 2023
This inappropriate left-alignment was introduced in 7bb7b1f. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: WHR <msl0000023508@gmail.com> Closes openzfs#14751
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Apr 20, 2023
This inappropriate left-alignment was introduced in 7bb7b1f. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: WHR <msl0000023508@gmail.com> Closes openzfs#14751
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Apr 30, 2023
This inappropriate left-alignment was introduced in 7bb7b1f. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Matthew Ahrens <mahrens@delphix.com> Reviewed-by: Tino Reichardt <milky-zfs@mcmilk.de> Signed-off-by: WHR <msl0000023508@gmail.com> Closes openzfs#14751
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fix #14749.
Description
See the title and #14749.
How Has This Been Tested?
Tested locally.
Types of changes
Checklist:
Signed-off-by.