Silence clang warning of flexible array not at end #14764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 18, 2023 07:13
Signed-off-by: Youzhong Yang <yyang@mathworks.com>
Signed-off-by: Youzhong Yang <yyang@mathworks.com>
behlendorf
reviewed
Apr 18, 2023
Signed-off-by: Youzhong Yang <yyang@mathworks.com>
lundman
approved these changes
Apr 18, 2023
behlendorf
approved these changes
Apr 19, 2023
behlendorf
added
Status: Accepted
13 tasks
|
This is technically a violation of the C standard, which could be a source of future miscompilation headaches. :/ |
andrewc12
pushed a commit
to andrewc12/openzfs
that referenced
this pull request
Apr 30, 2023
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Signed-off-by: Youzhong Yang <yyang@mathworks.com> Closes openzfs#14764
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jun 2, 2023
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Signed-off-by: Youzhong Yang <yyang@mathworks.com> Closes openzfs#14764
tonyhutter
pushed a commit
that referenced
this pull request
Jun 5, 2023
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Signed-off-by: Youzhong Yang <yyang@mathworks.com> Closes #14764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#14737 breaks FreeBSD build when clang is used, we need to make both Linux and FreeBSD happy.
Description
As lundman pointed out, #pragma clang diagnostic ignored may help. I don't have a FreeBSD host to try out, so we will let CI to figure out. If this one works, #14763 will be cancelled.
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.