Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZTS: Debug zfs_share_concurrent_shares failure #15379

Merged

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Debug zfs_share_concurrent_shares test failures observed on Fedora.

https://build.openzfs.org/builders/Fedora%2037%20x86_64%20%28TEST%29/builds/506/steps/shell_4/logs/summary

Description

Update zfs_share_concurrent_shares test case to wait a few seconds and recheck that the filesystem isn't shared. The intent here is determine the nature of the error and if it may be a race.

How Has This Been Tested?

This has been fairly consistently reproducible in the CI so we're going to rely on it for testing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Component: Test Suite Indicates an issue with the test framework or a test case label Oct 9, 2023
@behlendorf behlendorf force-pushed the debug-zfs_share_concurrent_shares branch 2 times, most recently from b32bc0a to 1656992 Compare October 10, 2023 00:30
@behlendorf
Copy link
Contributor Author

Re-based and pushed. No failure was observed on Fedora37,38 on during the first run.

@behlendorf behlendorf force-pushed the debug-zfs_share_concurrent_shares branch from 1656992 to bcddd55 Compare October 10, 2023 00:54
Update zfs_share_concurrent_shares test case to wait a few seconds
and recheck that the filesystem isn't shared.  The intent here is
determine the nature of the error and if it may be a race.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf force-pushed the debug-zfs_share_concurrent_shares branch from bcddd55 to 69c157b Compare October 10, 2023 16:12
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Component: Test Suite Indicates an issue with the test framework or a test case labels Oct 10, 2023
@behlendorf behlendorf merged commit 9facf2d into openzfs:master Oct 10, 2023
23 of 26 checks passed
behlendorf added a commit that referenced this pull request Oct 11, 2023
Update zfs_share_concurrent_shares test case to wait a few seconds
and recheck that the filesystem isn't shared.  The intent here is
determine the nature of the error and if it may be a race.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by:  Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #15379
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
Update zfs_share_concurrent_shares test case to wait a few seconds
and recheck that the filesystem isn't shared.  The intent here is
determine the nature of the error and if it may be a race.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by:  Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#15379
tonyhutter pushed a commit that referenced this pull request Feb 26, 2024
Update zfs_share_concurrent_shares test case to wait a few seconds
and recheck that the filesystem isn't shared.  The intent here is
determine the nature of the error and if it may be a race.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by:  Umer Saleem <usaleem@ixsystems.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #15379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants