Workaround UBSAN errors for variable arrays #15510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules. It is based off of the patch from openzfs#15460. Addresses: openzfs#15145 Signed-off-by: Tony Hutter <hutter2@llnl.gov> Co-authored-by: Tony Hutter <hutter2@llnl.gov> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
13 tasks
|
We really need a test suite run with UBSAN enabled (like Ubuntu 23.10) to test this before it gets merged. |
behlendorf
approved these changes
Nov 10, 2023
|
I applied this on our kernel with UBSAN_BOUNDS checking enabled again, then booted that on a test-host with ZFS on root, I could not see the oopses again that we observed on that exact platform previously. So, consider this: |
ProxBot
pushed a commit
to proxmox/pve-kernel
that referenced
this pull request
Nov 12, 2023
We have a slightly better fix where only a few targeted ZFS module parts are added to the UBSAN ignore-list, so the rest of the kernel still gets exposure. Link: openzfs/zfs#15510 Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
behlendorf
added
Status: Accepted
ixhamza
pushed a commit
to truenas/zfs
that referenced
this pull request
Nov 20, 2023
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules. It is based off of the patch from openzfs#15460. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Issue openzfs#15145 Closes openzfs#15510
jiangcuo
pushed a commit
to jiangcuo/zfsonlinux
that referenced
this pull request
Dec 2, 2023
Link: openzfs/zfs#15510 Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Dec 12, 2023
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules. It is based off of the patch from openzfs#15460. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Issue openzfs#15145 Closes openzfs#15510
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jan 26, 2024
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules. It is based off of the patch from openzfs#15460. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Issue openzfs#15145 Closes openzfs#15510
6 tasks
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Jan 29, 2024
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules. It is based off of the patch from openzfs#15460. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Issue openzfs#15145 Closes openzfs#15510
behlendorf
pushed a commit
that referenced
this pull request
Feb 5, 2024
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules. It is based off of the patch from #15460. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com> Signed-off-by: Tony Hutter <hutter2@llnl.gov> Issue #15145 Closes #15510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Workaround #15145
Description
This gets around UBSAN errors when using arrays at the end of structs. It converts some zero-length arrays to variable length arrays and disables UBSAN checking on certain modules.
It is based off of the patch from #15460.
How Has This Been Tested?
Reproduced original issue on Ubuntu 23.10 (which has UBSAN enabled by default). Applied patch, did a module load and import and saw no UBSAN errors.
Types of changes
Checklist:
Signed-off-by.