Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZIL: Assert record sizes in different places #15517

Merged
merged 1 commit into from Nov 28, 2023
Merged

ZIL: Assert record sizes in different places #15517

merged 1 commit into from Nov 28, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Nov 12, 2023 •
edited

This should make sure we have log written without overflows.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin force-pushed the zil_assert branch 2 times, most recently from c428dfa to 98498c5 Compare November 12, 2023 23:47
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 13, 2023
@amotin amotin mentioned this pull request Nov 13, 2023
Closed
@amotin amotin changed the title ZIL: Assert record sizes on claim and replay ZIL: Assert record sizes on claim, replay and free Nov 13, 2023
@amotin
Copy link
Member Author

amotin commented Nov 13, 2023

Added assertions also to ZIL free.

@amotin amotin force-pushed the zil_assert branch 2 times, most recently from 64665d9 to 078a93a Compare November 18, 2023 18:31
@amotin amotin changed the title ZIL: Assert record sizes on claim, replay and free ZIL: Assert record sizes in different places Nov 18, 2023
@amotin
Copy link
Member Author

amotin commented Nov 18, 2023

I've added more assertions in ZIL write path, checksuming and encryption.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Nov 27, 2023
@amotin
ZIL: Assert record sizes in different places
2516cc8 
This should make sure we have log written without overflows.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@behlendorf behlendorf merged commit 2a27fd4 into openzfs:master Nov 28, 2023
24 of 26 checks passed
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@amotin @lundman
ZIL: Assert record sizes in different places
5ced949 
This should make sure we have log written without overflows.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15517
@amotin amotin deleted the zil_assert branch December 18, 2023 15:26
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Dec 27, 2023
@amotin @mmatuska
ZIL: Assert record sizes in different places
f9abc6d 
This should make sure we have log written without overflows.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15517
@mmatuska mmatuska mentioned this pull request Dec 27, 2023
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Jan 9, 2024
@amotin @behlendorf
ZIL: Assert record sizes in different places
ad47eca 
This should make sure we have log written without overflows.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #15517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amotin @behlendorf