Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow block cloning across encrypted datasets #15545

Closed
wants to merge 1 commit into from

Conversation

mmatuska
Copy link
Contributor

Motivation and Context

When two datasets share the same master encryption key, it is safe to clone encrypted blocks. Currently only snapshots and clones of a dataset share with it the same encryption key.

Description

Allow block cloning for datasets with the same master key.

How Has This Been Tested?

TBD extending the test suite

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

When two datasets share the same master encryption key, it is safe
to clone encrypted blocks. Currently only snapshots and clones
of a dataset share with it the same encryption key.

Signed-off-by: Martin Matuska <mm@FreeBSD.org>
@mmatuska
Copy link
Contributor Author

@oromenahar could you please help me out with the tests here?

@oromenahar
Copy link
Contributor

going to test this agains my test. Give me some time.

@oromenahar
Copy link
Contributor

@mmatuska looks like this works, I'm going to update my PR with your code and force push it with a new test case. I think we can close this PR after I updated #15544

@oromenahar
Copy link
Contributor

was working on something similar, you were a little bit faster than me.

@oromenahar
Copy link
Contributor

I have updated my PR with your code and a new test.

@behlendorf behlendorf added Status: Code Review Needed Ready for review and testing Component: Encryption "native encryption" feature labels Nov 27, 2023
@amotin
Copy link
Member

amotin commented Nov 29, 2023

Lets close this in favor of #15544 .

@amotin amotin closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Encryption "native encryption" feature Status: Code Review Needed Ready for review and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants