Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zdb: Dump encrypted write and clone ZIL records #15629

Merged
merged 1 commit into from Dec 6, 2023
Merged

zdb: Dump encrypted write and clone ZIL records #15629

merged 1 commit into from Dec 6, 2023

Conversation

amotin
Copy link
Member

@amotin amotin commented Dec 4, 2023 •
edited

Block pointers are not encrypted in TX_WRITE and TX_CLONE_RANGE records, so we can dump them, that may be useful for debugging.

Related to #15543 .

How Has This Been Tested?

                TX_WRITE            len    192, txg 22, seq 1029
                        (encrypted)
                        has blkptr, will claim
                        DVA[0]=<0:1400049000:20000> salt=7b5f5c3213168204 iv=57d5617d90d181ac:fe4f1d3b [L0 ZFS plain file] fletcher4 uncompressed encrypted LE contiguous unique single size=20000L/20000P birth=23L/23P fill=1 cksum=0d211a999613c66d:2a2d480b7a1f4d4f:ed083691c085519b:71a54ac80c282ef2

                TX_CLONE_RANGE      len    328, txg 22, seq 1027
                        (encrypted)
                        [1/2] DVA[0]=<0:407fec000:20000> salt=7b5f5c3213168204 iv=fa8fb69285bd5b39:da573694 [L0 ZFS plain file] fletcher4 uncompressed encrypted LE contiguous unique single size=20000L/20000P birth=15L/15P fill=1 cksum=eaad24461dee12c4:2a172c6c49eb4307:9b55b4d11a6cdb51:be1972cbf00e5bab
                        [2/2] DVA[0]=<0:40800c000:20000> salt=7b5f5c3213168204 iv=ab058cfdcec81e19:670af280 [L0 ZFS plain file] fletcher4 uncompressed encrypted LE contiguous unique single size=20000L/20000P birth=15L/15P fill=1 cksum=55ec155cbfcf160a:2d6f680ccd4b8e00:6993c9be9290a49f:c34a3481c217c394

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin amotin added the Status: Code Review Needed Ready for review and testing label Dec 4, 2023
@amotin amotin force-pushed the zdb_enc_bp branch 2 times, most recently from fa17cd9 to 4ca1427 Compare December 4, 2023 18:37
@amotin
zdb: Dump encrypted write and clone ZIL records
5d56660 
Block pointers are not encrypted in TX_WRITE and TX_CLONE_RANGE
records, so we can dump them, that may be useful for debugging.

Related to openzfs#15543.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 5, 2023
@behlendorf behlendorf merged commit f9765b1 into openzfs:master Dec 6, 2023
23 of 26 checks passed
@amotin amotin deleted the zdb_enc_bp branch December 6, 2023 20:41
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@amotin @lundman
zdb: Dump encrypted write and clone ZIL records
f490f2e 
Block pointers are not encrypted in TX_WRITE and TX_CLONE_RANGE
records, so we can dump them, that may be useful for debugging.

Related to openzfs#15543.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15629
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Dec 27, 2023
@amotin @mmatuska
zdb: Dump encrypted write and clone ZIL records
4d74a5d 
Block pointers are not encrypted in TX_WRITE and TX_CLONE_RANGE
records, so we can dump them, that may be useful for debugging.

Related to openzfs#15543.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes openzfs#15629
@mmatuska mmatuska mentioned this pull request Dec 27, 2023
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request Jan 9, 2024
@amotin @behlendorf
zdb: Dump encrypted write and clone ZIL records
dea2d3c 
Block pointers are not encrypted in TX_WRITE and TX_CLONE_RANGE
records, so we can dump them, that may be useful for debugging.

Related to #15543.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #15629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amotin @behlendorf