Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable block_cloning tests on FreeBSD. #15749

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Rebased version of #15686. No changes.

Description

We want as many tests as possible to run on as many platforms as possible.
The following changes allow most of the block_cloning tests to be exercised also on FreeBSD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 9, 2024
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 12, 2024
@behlendorf behlendorf merged commit c4fa674 into openzfs:master Jan 12, 2024
24 of 26 checks passed
@behlendorf
Copy link
Contributor Author

@pjd I went ahead and merged this to move things forward, but according to the CI several of these tests are failing on FreeBSD. Could you take a look at what's going with these tests on FreeBSD.

@pjd
Copy link
Contributor

pjd commented Jan 13, 2024

@pjd I went ahead and merged this to move things forward, but according to the CI several of these tests are failing on FreeBSD. Could you take a look at what's going with these tests on FreeBSD.

Will do.

mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 17, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#15749
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 18, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#15749
mmatuska pushed a commit to mmatuska/zfs that referenced this pull request Jan 18, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#15749
behlendorf added a commit that referenced this pull request Jan 19, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes #15749
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#15749
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 13, 2024
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Closes openzfs#15749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants