Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spl: fix compilation without HAVE_BACKTRACE #16229

Merged
merged 1 commit into from
May 29, 2024

Conversation

mmatuska
Copy link
Contributor

@mmatuska mmatuska commented May 26, 2024

Motivation and Context

Without HAVE_BACKTRACE, the compilation of lib/libspl/backtrace.c fails on undefined __maybe_unused macro on both Linux and FreeBSD. This macro is defined in spl/sys/debug.h for both Linux and FreeBSD platforms.

Description

Add the sys/debug.h header to lib/libspl/backtrace.c

How Has This Been Tested?

Tested build on Linux, FreeBSD and FreeBSD base (bundled version of OpenZFS)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

The __maybe_unused macro is defined in spl/sys/debug.h

Signed-off-by: Martin Matuska <mm@FreeBSD.org>
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 29, 2024
@behlendorf behlendorf merged commit ae22044 into openzfs:master May 29, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants