Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 3.19 compat: file_inode was added #3084

Closed
wants to merge 1 commit into from
Closed

Linux 3.19 compat: file_inode was added #3084

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 7, 2015

fixes #2959

@FransUrbo
Copy link
Contributor

Thanx @Mic92. @behlendorf, we need this into 0.6.4 and I'll start testing right away...

@Mic92
Copy link
Contributor Author

Mic92 commented Feb 7, 2015

@FransUrbo I forgot to add the compatibility header file to include/linux/Makefile.am

@ilovezfs
Copy link
Contributor

ilovezfs commented Feb 7, 2015

If you force push, GitHub will automatically update the pull request.

@FransUrbo
Copy link
Contributor

@maci0 Ok, could you force-push the changes? I haven't gotten this far yet. I had to create a new latest Linux kernel. Can't find the 3.19-rcSOMETHING i built a couple of months (weeks? :) ago and that's going to take a while..

@Mic92
Copy link
Contributor Author

Mic92 commented Feb 7, 2015

@ilovezfs @FransUrbo done. My internet connection broke in the same second.

@FransUrbo
Copy link
Contributor

Works like a charm on both 3.18.0-rc3 and 3.19.0-rc7+git26cdd (the very, very latest GIT version). This on ZoL GIT master (with some of my own stuff).

@behlendorf
Copy link
Contributor

@Mic92 Nice, this is exactly what I had in mind. Could you please just fix the two style issues which were flagged and repush the patch.

./include/linux/fs_compat.h: 34: indent by spaces instead of tabs
./include/linux/fs_compat.h: 34: unparenthesized return expression
make: *** [checkstyle] Error 1

@behlendorf behlendorf added this to the 0.6.4 milestone Feb 9, 2015
@behlendorf behlendorf added the Type: Building Indicates an issue related to building binaries label Feb 9, 2015
@Mic92
Linux 3.19 compat: file_inode was added
9b6498b 
struct access f->f_dentry->d_inode was replaced by accessor function
file_inode(f)
@Mic92
Copy link
Contributor Author

Mic92 commented Feb 10, 2015

@behlendorf done

@behlendorf
Copy link
Contributor

@Mic92 Thanks for taking care of this. I've merged your fix, the only minor change I made was moving the wrapper function in to vfs_compat.h. Arguably it should be in file_compat.h but that's still part of the SPL layer for now.

534759f Linux 3.19 compat: file_inode was added

behlendorf pushed a commit that referenced this pull request Mar 18, 2015
@Mic92 @behlendorf
Linux 3.19 compat: file_inode was added
157f14a 
struct access f->f_dentry->d_inode was replaced by accessor function
file_inode(f)

Signed-off-by: Joerg Thalheim <joerg@higgsboson.tk>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3084
DeHackEd pushed a commit to DeHackEd/zfs that referenced this pull request Apr 4, 2015
@Mic92 @DeHackEd
Linux 3.19 compat: file_inode was added
85ef88c 
struct access f->f_dentry->d_inode was replaced by accessor function
file_inode(f)

Signed-off-by: Joerg Thalheim <joerg@higgsboson.tk>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3084
DeHackEd pushed a commit to DeHackEd/zfs that referenced this pull request Apr 5, 2015
@Mic92 @DeHackEd
Linux 3.19 compat: file_inode was added
6264b39 
struct access f->f_dentry->d_inode was replaced by accessor function
file_inode(f)

Signed-off-by: Joerg Thalheim <joerg@higgsboson.tk>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3084
dweeezil pushed a commit to dweeezil/zfs that referenced this pull request Sep 19, 2015
@Mic92 @dweeezil
Linux 3.19 compat: file_inode was added
7cb92af 
struct access f->f_dentry->d_inode was replaced by accessor function
file_inode(f)

Signed-off-by: Joerg Thalheim <joerg@higgsboson.tk>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes openzfs#3084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Building Indicates an issue related to building binaries
Projects
None yet
Milestone
0.6.4
Development

Successfully merging this pull request may close these issues.

error: 'struct file' has no member named 'f_dentry'
4 participants
@Mic92 @FransUrbo @ilovezfs @behlendorf