Honor xattr=sa dataset property #3788
Conversation
|
I really wish we could move to a reference-counted feature flag to manage SA xattrs and use the |
|
One other salient point is that Solaris has |
|
We should plan to do exactly that for the next tag. In addition I think we should take the opportunity to fix some of the other rough edges too. We'll want to carefully think through the behavior we want from a user perspective. In the meanwhile we can address this in a point release with a minimal fix. |
|
Updated patch to use saxattr and dirxattr mount options instead of xattr=sa and xattr=dir. This mirrors the valid dataset property values and adheres to mount option naming conventions. Also eliminates ugly string handling from the option parsing code. |
ZFS incorrectly uses directory-based extended attributes even when xattr=sa is specified as a dataset property or mount option. Support to honor temporary mount options including "xattr" was added in commit 0282c41. There are two issues with the mount option handling: * Libzfs has historically included "xattr" in its list of default mount options. This overrides the dataset property, so the dataset is always configured to use directory-based xattrs even when the xattr dataset property is set to off or sa. Address this by removing "xattr" from the set of default mount options in libzfs. * There was no way to enable system attribute-based extended attributes using temporary mount options. Add the mount options "saxattr" and "dirxattr" which enable the xattr behavior their names suggest. This approach has the advantages of mirroring the valid xattr dataset property values and following existing conventions for mount option names. Issue openzfs#3787 Signed-off-by: Ned Bass <bass6@llnl.gov>
|
Added new mount options to |
|
Merged as: 3af56fd Honor xattr=sa dataset property |
ZFS incorrectly uses directory-based extended attributes even when
xattr=sa is specified as a dataset property or mount option. Support to
honor temporary mount options including "xattr" was added in commit
0282c41. There are two issues with the
mount option handling:
options with no value specified. Omitting the value implies xattr=on or
directory-based xattrs, so the dataset is configured to use
directory-based xattrs regardless of the xattr dataset property value.
Address this by removing "xattr" from the list of default mount
options.
boolean value. Even if xattr=sa is specified, the parser translates
that to xattr=on. Address this by treating the option as a scalar
value.
Issue #3787
Signed-off-by: Ned Bass bass6@llnl.gov