Fix write(2) return zero bug from 933ec99 #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuxoko, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf, @dweeezil and @ryao to be potential reviewers. |
|
7a7c706 (tuxoko/iter_fix) resolves #5720 for me. |
|
@inkdot7 Thanks for testing. |
behlendorf
reviewed
Feb 1, 2017
module/zfs/zpl_file.c
Outdated
| @@ -387,6 +387,8 @@ zpl_iter_write(struct kiocb *kiocb, struct iov_iter *from) | |||
|
|
|||
| count = iov_iter_count(from); | |||
| ret = generic_write_checks(file, &kiocb->ki_pos, &count, isblk); | |||
| if (ret < 0) | |||
| return (ret); | |||
There was a problem hiding this comment.
Let's make the same change to zpl_aio_write.
There was a problem hiding this comment.
Or I can make both != 0.
There was a problem hiding this comment.
That'd be fine, I think sameness is the important thing.
module/zfs/zpl_file.c
Outdated
| @@ -395,9 +397,9 @@ zpl_iter_write(struct kiocb *kiocb, struct iov_iter *from) | |||
| */ | |||
| ret = generic_write_checks(kiocb, from); | |||
| count = ret; | |||
There was a problem hiding this comment.
You could move the count = ret; assignment after the ret check now, but it really doesn't matter.
For generic_write_checks with 2 args, we can exit when it returns zero because it means count is zero. However this is not the case for generic_write_checks with 4 args, where zero means no error. Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
behlendorf
approved these changes
Feb 2, 2017
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Feb 2, 2017
For generic_write_checks with 2 args, we can exit when it returns zero because it means count is zero. However this is not the case for generic_write_checks with 4 args, where zero means no error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Haakan T Johansson <f96hajo@chalmers.se> Signed-off-by: Chunwei Chen <david.chen@osnexus.com> Closes openzfs#5720 Closes openzfs#5726
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Feb 2, 2017
For generic_write_checks with 2 args, we can exit when it returns zero because it means count is zero. However this is not the case for generic_write_checks with 4 args, where zero means no error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Haakan T Johansson <f96hajo@chalmers.se> Signed-off-by: Chunwei Chen <david.chen@osnexus.com> Closes openzfs#5720 Closes openzfs#5726 Requires-builders: style
behlendorf
pushed a commit
that referenced
this pull request
Feb 3, 2017
For generic_write_checks with 2 args, we can exit when it returns zero because it means count is zero. However this is not the case for generic_write_checks with 4 args, where zero means no error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Haakan T Johansson <f96hajo@chalmers.se> Signed-off-by: Chunwei Chen <david.chen@osnexus.com> Closes #5720 Closes #5726
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
For generic_write_checks with 2 args, we can exit when it returns zero because it means count is zero. However this is not the case for generic_write_checks with 4 args, where zero means no error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Haakan T Johansson <f96hajo@chalmers.se> Signed-off-by: Chunwei Chen <david.chen@osnexus.com> Closes openzfs#5720 Closes openzfs#5726
wli5
pushed a commit
to wli5/zfs
that referenced
this pull request
Feb 28, 2017
For generic_write_checks with 2 args, we can exit when it returns zero because it means count is zero. However this is not the case for generic_write_checks with 4 args, where zero means no error. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Haakan T Johansson <f96hajo@chalmers.se> Signed-off-by: Chunwei Chen <david.chen@osnexus.com> Closes openzfs#5720 Closes openzfs#5726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For generic_write_checks with 2 args, we can exit when it returns zero because
it means count is zero. However this is not the case for generic_write_checks
with 4 args, where zero means no error.
Signed-off-by: Chunwei Chen david.chen@osnexus.com