Increase default arc_c_min #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the default arc_c_min value to which whichever is larger, either 32M or 1/32 of total system memory. This is advantageous for systems with more than 1G of memory where performance issues may occur when the ARC is allowed to collapse below a minimum size. At the same time we want to use the bare minimum value which is still functional so the filesystem can be used in very low memory environments. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
13 tasks
gmelikov
approved these changes
Sep 19, 2017
dweeezil
approved these changes
Sep 19, 2017
There was a problem hiding this comment.
@behlendorf I've thought something like this would be a good idea for some time, but always wondered what a reasonable default would be. The allmem/32 seems quite reasonable.
dinatale2
approved these changes
Sep 19, 2017
Codecov Report
@@ Coverage Diff @@
## master #6659 +/- ##
==========================================
+ Coverage 67.61% 68.03% +0.41%
==========================================
Files 196 196
Lines 70349 70348 -1
Branches 13921 13921
==========================================
+ Hits 47569 47862 +293
+ Misses 17444 17111 -333
- Partials 5336 5375 +39
Continue to review full report at Codecov.
|
|
On 2017-09-20 12:16, kpande wrote:
what's with the code coverage spam?
It's a welcome change from Nigerian Prince and penis enlargement emails?
|
|
@kpande we're extending the automated testing to provide code coverage reports for PRs. |
tonyhutter
pushed a commit
that referenced
this pull request
Sep 20, 2017
Increase the default arc_c_min value to which whichever is larger, either 32M or 1/32 of total system memory. This is advantageous for systems with more than 1G of memory where performance issues may occur when the ARC is allowed to collapse below a minimum size. At the same time we want to use the bare minimum value which is still functional so the filesystem can be used in very low memory environments. Reviewed-by: Tim Chase <tim@chase2k.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #6659
Fabian-Gruenbichler
pushed a commit
to Fabian-Gruenbichler/zfs
that referenced
this pull request
Sep 29, 2017
Increase the default arc_c_min value to which whichever is larger, either 32M or 1/32 of total system memory. This is advantageous for systems with more than 1G of memory where performance issues may occur when the ARC is allowed to collapse below a minimum size. At the same time we want to use the bare minimum value which is still functional so the filesystem can be used in very low memory environments. Reviewed-by: Tim Chase <tim@chase2k.com> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov> Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes openzfs#6659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the default arc_c_min value to which whichever is larger,
either 32M or 1/32 of total system memory. This is advantageous for
systems with more than 1G of memory where performance issues may
occur when the ARC is allowed to collapse below a minimum size.
At the same time we want to use the bare minimum value which is
still functional so the filesystem can be used in very low memory
environments.
Motivation and Context
By increasing the default
arc_c_minon systems which have moretotal memory available it's possible to avoid some performance
pathologiies caused by the ARC collapsing due to competing
application demand for memory. The change complements recent
fixes such as 787acae which prevent the ARC from mistakenly
decreasing in size needlessly.
How Has This Been Tested?
zfs_arc_c_minfor their workload.Types of changes
Checklist:
Signed-off-by.