Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenZFS 8906 - uts: illumos rootfs should support salted cksum #7714

Closed
wants to merge 1 commit into from

Conversation

behlendorf
Copy link
Contributor

Description

Porting notes:

Motivation and Context

OpenZFS-issue: https://illumos.org/issues/8906
OpenZFS-commit: openzfs/openzfs@7dec52f
Issue #6501

How Has This Been Tested?

Locally built, untested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commit messages are properly formatted and contain Signed-off-by.
  • Change has been approved by a ZFS on Linux member.

@bunder2015
Copy link
Contributor

bunder2015 commented Jul 14, 2018

I really think we should leave a note in the man pages along the lines of "grub still can't boot these pools", and/or that "EFI without grub is the only known working configuration".

edit: or perhaps "with a boot method capable of reading the root dataset or able to load the kernel without reading the root dataset"

Porting notes:
* As of grub-2.02 these checksums are not supported.  However, as
  pointed out in openzfs#6501 there are alternatives such as EFISTUB which
  work and have no such restriction.  A warning was added to the
  checksum property section of the zfs.8 man page.

Authored by: Toomas Soome <tsoome@me.com>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>

OpenZFS-issue: https://illumos.org/issues/8906
OpenZFS-commit: openzfs/openzfs@7dec52f
Issue openzfs#6501
@behlendorf
Copy link
Contributor Author

Refreshed to include a warning about the GRUB incompatibly in the checksum property section.

@codecov
Copy link

codecov bot commented Jul 26, 2018

Codecov Report

Merging #7714 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7714      +/-   ##
==========================================
+ Coverage   78.28%   78.28%   +<.01%     
==========================================
  Files         368      368              
  Lines      111981   111975       -6     
==========================================
- Hits        87665    87664       -1     
+ Misses      24316    24311       -5
Flag Coverage Δ
#kernel 78.85% <ø> (+0.05%) ⬆️
#user 67.48% <ø> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e106a7b...f5dc0cf. Read the comment docs.

tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 15, 2018
Porting notes:
* As of grub-2.02 these checksums are not supported.  However, as
  pointed out in openzfs#6501 there are alternatives such as EFISTUB which
  work and have no such restriction.  A warning was added to the
  checksum property section of the zfs.8 man page.

Authored by: Toomas Soome <tsoome@me.com>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>

OpenZFS-issue: https://illumos.org/issues/8906
OpenZFS-commit: openzfs/openzfs@7dec52f
Closes openzfs#6501
Closes openzfs#7714
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 23, 2018
Porting notes:
* As of grub-2.02 these checksums are not supported.  However, as
  pointed out in openzfs#6501 there are alternatives such as EFISTUB which
  work and have no such restriction.  A warning was added to the
  checksum property section of the zfs.8 man page.

Authored by: Toomas Soome <tsoome@me.com>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>

OpenZFS-issue: https://illumos.org/issues/8906
OpenZFS-commit: openzfs/openzfs@7dec52f
Closes openzfs#6501
Closes openzfs#7714
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Aug 27, 2018
Porting notes:
* As of grub-2.02 these checksums are not supported.  However, as
  pointed out in openzfs#6501 there are alternatives such as EFISTUB which
  work and have no such restriction.  A warning was added to the
  checksum property section of the zfs.8 man page.

Authored by: Toomas Soome <tsoome@me.com>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>

OpenZFS-issue: https://illumos.org/issues/8906
OpenZFS-commit: openzfs/openzfs@7dec52f
Closes openzfs#6501
Closes openzfs#7714
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 5, 2018
Porting notes:
* As of grub-2.02 these checksums are not supported.  However, as
  pointed out in openzfs#6501 there are alternatives such as EFISTUB which
  work and have no such restriction.  A warning was added to the
  checksum property section of the zfs.8 man page.

Authored by: Toomas Soome <tsoome@me.com>
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>

OpenZFS-issue: https://illumos.org/issues/8906
OpenZFS-commit: openzfs/openzfs@7dec52f
Closes openzfs#6501
Closes openzfs#7714
@behlendorf behlendorf deleted the openzfs-8906 branch April 19, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants