Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more refquota tests #9139

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Add more refquota tests #9139

merged 2 commits into from
Aug 19, 2019

Conversation

pcd1193182
Copy link
Contributor

Signed-off-by: Paul Dagnelie pcd@delphix.com

Motivation and Context

It used to be possible for zfs receive (and other operations related to clone swap) to bypass refquotas. This can cause a number of issues, and there should be an automated test for it.

Description

Added tests for rollback and receive not overriding refquota

How Has This Been Tested?

Ran the refquota test suite.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@pcd1193182
Add more refquota tests
03305a6 
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
@ahrens ahrens added Status: Code Review Needed Ready for review and testing Component: Test Suite Indicates an issue with the test framework or a test case labels Aug 8, 2019
@ahrens ahrens requested a review from jwk404 August 8, 2019 02:52
@codecov
Copy link

codecov bot commented Aug 8, 2019 •
edited
Loading

Codecov Report

Merging #9139 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9139      +/-   ##
==========================================
- Coverage   79.33%   79.12%   -0.21%     
==========================================
  Files         400      400              
  Lines      121692   121692              
==========================================
- Hits        96542    96288     -254     
- Misses      25150    25404     +254
Flag Coverage Δ
#kernel 79.7% <ø> (-0.11%) ⬇️
#user 66.78% <ø> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81f179...fbbf33f. Read the comment docs.

@behlendorf
Copy link
Contributor

@pcd1193182 I'm a little confused, I see you pushed a follow up commit to set spa_asize_inflation = 2, I believe to resolve the refquota_008_neg failures. Did you intend for this to be part of the final merged commit, or were you just debugging with the CI?

@pcd1193182
Copy link
Contributor Author

@behlendorf That is intended to be part of the final PR.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 19, 2019
@behlendorf behlendorf merged commit 1a26cb6 into openzfs:master Aug 19, 2019
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 24, 2019
@pcd1193182 @tonyhutter
Add more refquota tests
8fe405d 
It used to be possible for zfs receive (and other operations related
to clone swap) to bypass refquotas. This can cause a number of issues,
and there should be an automated test for it.

Added tests for rollback and receive not overriding refquota.

Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#9139
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@pcd1193182 @tonyhutter
Add more refquota tests
1a0b849 
It used to be possible for zfs receive (and other operations related
to clone swap) to bypass refquotas. This can cause a number of issues,
and there should be an automated test for it.

Added tests for rollback and receive not overriding refquota.

Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes openzfs#9139
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@pcd1193182 @tonyhutter
Add more refquota tests
72dbc01 
It used to be possible for zfs receive (and other operations related
to clone swap) to bypass refquotas. This can cause a number of issues,
and there should be an automated test for it.

Added tests for rollback and receive not overriding refquota.

Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed-by: John Kennedy <john.kennedy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Paul Dagnelie <pcd@delphix.com>
Closes #9139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@jwk404 jwk404 jwk404 approved these changes

@pzakha pzakha pzakha approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pcd1193182 @behlendorf @jwk404 @pzakha @ahrens